Skip to content

Commit f30670a

Browse files
gmarcianigmarciani
committed
[PCAPI] Add the following CloudFormation stack status to the PCAPI definition:
 - IMPORT_IN_PROGRESS - IMPORT_COMPLETE - IMPORT_ROLLBACK_IN_PROGRESS - IMPORT_ROLLBACK_FAILED - IMPORT_ROLLBACK_COMPLETE - REVIEW_IN_PROGRESS - UPDATE_FAILED Signed-off-by: Giacomo Marciani <[email protected]>
1 parent 941bd2a commit f30670a

File tree

6 files changed

+35
-5
lines changed

6 files changed

+35
-5
lines changed

‎CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ CHANGELOG
1919
- Removing `/etc/profile.d/pcluster.sh` so that it's not executed at every user login and
2020
`cfn_bootstrap_virtualenv` is not added in PATH environment variable.
2121
- Fix ParallelCluster API spec by replacing in `DescribeCluster` response the field `failureReason` with `failures`.
22+
- Fix ParallelCluster API spec by adding the CloudFormation stack status that were missing:
23+
`IMPORT_*`, `REVIEW_IN_PROGRESS` and `UPDATE_FAILED`.
2224

2325
**CHANGES**
2426
- CentOS 7 is no longer supported.

‎api/client/src/docs/CloudFormationStackStatus.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
## Properties
55
Name | Type | Description | Notes
66
------------ | ------------- | ------------- | -------------
7-
**value** | **str** | | must be one of ["CREATE_IN_PROGRESS", "CREATE_FAILED", "CREATE_COMPLETE", "ROLLBACK_IN_PROGRESS", "ROLLBACK_FAILED", "ROLLBACK_COMPLETE", "DELETE_IN_PROGRESS", "DELETE_FAILED", "DELETE_COMPLETE", "UPDATE_IN_PROGRESS", "UPDATE_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_COMPLETE", "UPDATE_ROLLBACK_IN_PROGRESS", "UPDATE_ROLLBACK_FAILED", "UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_ROLLBACK_COMPLETE", ]
7+
**value** | **str** | | must be one of ["CREATE_IN_PROGRESS", "CREATE_FAILED", "CREATE_COMPLETE", "IMPORT_IN_PROGRESS", "IMPORT_COMPLETE", "IMPORT_ROLLBACK_IN_PROGRESS", "IMPORT_ROLLBACK_FAILED", "IMPORT_ROLLBACK_COMPLETE", "ROLLBACK_IN_PROGRESS", "ROLLBACK_FAILED", "ROLLBACK_COMPLETE", "DELETE_IN_PROGRESS", "DELETE_FAILED", "DELETE_COMPLETE", "REVIEW_IN_PROGRESS", "UPDATE_IN_PROGRESS", "UPDATE_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_COMPLETE", "UPDATE_FAILED", "UPDATE_ROLLBACK_IN_PROGRESS", "UPDATE_ROLLBACK_FAILED", "UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_ROLLBACK_COMPLETE", ]
88

99
[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)
1010

‎api/client/src/pcluster_client/model/cloud_formation_stack_status.py

+11-4
Original file line numberDiff line numberDiff line change
@@ -55,15 +55,22 @@ class CloudFormationStackStatus(ModelSimple):
5555
'CREATE_IN_PROGRESS': "CREATE_IN_PROGRESS",
5656
'CREATE_FAILED': "CREATE_FAILED",
5757
'CREATE_COMPLETE': "CREATE_COMPLETE",
58+
'IMPORT_IN_PROGRESS': "IMPORT_IN_PROGRESS",
59+
'IMPORT_COMPLETE': "IMPORT_COMPLETE",
60+
'IMPORT_ROLLBACK_IN_PROGRESS': "IMPORT_ROLLBACK_IN_PROGRESS",
61+
'IMPORT_ROLLBACK_FAILED': "IMPORT_ROLLBACK_FAILED",
62+
'IMPORT_ROLLBACK_COMPLETE': "IMPORT_ROLLBACK_COMPLETE",
5863
'ROLLBACK_IN_PROGRESS': "ROLLBACK_IN_PROGRESS",
5964
'ROLLBACK_FAILED': "ROLLBACK_FAILED",
6065
'ROLLBACK_COMPLETE': "ROLLBACK_COMPLETE",
6166
'DELETE_IN_PROGRESS': "DELETE_IN_PROGRESS",
6267
'DELETE_FAILED': "DELETE_FAILED",
6368
'DELETE_COMPLETE': "DELETE_COMPLETE",
69+
'REVIEW_IN_PROGRESS': "REVIEW_IN_PROGRESS",
6470
'UPDATE_IN_PROGRESS': "UPDATE_IN_PROGRESS",
6571
'UPDATE_COMPLETE_CLEANUP_IN_PROGRESS': "UPDATE_COMPLETE_CLEANUP_IN_PROGRESS",
6672
'UPDATE_COMPLETE': "UPDATE_COMPLETE",
73+
'UPDATE_FAILED': "UPDATE_FAILED",
6774
'UPDATE_ROLLBACK_IN_PROGRESS': "UPDATE_ROLLBACK_IN_PROGRESS",
6875
'UPDATE_ROLLBACK_FAILED': "UPDATE_ROLLBACK_FAILED",
6976
'UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS': "UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS",
@@ -119,10 +126,10 @@ def __init__(self, *args, **kwargs):
119126
Note that value can be passed either in args or in kwargs, but not in both.
120127
121128
Args:
122-
args[0] (str):, must be one of ["CREATE_IN_PROGRESS", "CREATE_FAILED", "CREATE_COMPLETE", "ROLLBACK_IN_PROGRESS", "ROLLBACK_FAILED", "ROLLBACK_COMPLETE", "DELETE_IN_PROGRESS", "DELETE_FAILED", "DELETE_COMPLETE", "UPDATE_IN_PROGRESS", "UPDATE_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_COMPLETE", "UPDATE_ROLLBACK_IN_PROGRESS", "UPDATE_ROLLBACK_FAILED", "UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_ROLLBACK_COMPLETE", ] # noqa: E501
129+
args[0] (str):, must be one of ["CREATE_IN_PROGRESS", "CREATE_FAILED", "CREATE_COMPLETE", "IMPORT_IN_PROGRESS", "IMPORT_COMPLETE", "IMPORT_ROLLBACK_IN_PROGRESS", "IMPORT_ROLLBACK_FAILED", "IMPORT_ROLLBACK_COMPLETE", "ROLLBACK_IN_PROGRESS", "ROLLBACK_FAILED", "ROLLBACK_COMPLETE", "DELETE_IN_PROGRESS", "DELETE_FAILED", "DELETE_COMPLETE", "REVIEW_IN_PROGRESS", "UPDATE_IN_PROGRESS", "UPDATE_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_COMPLETE", "UPDATE_FAILED", "UPDATE_ROLLBACK_IN_PROGRESS", "UPDATE_ROLLBACK_FAILED", "UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_ROLLBACK_COMPLETE", ] # noqa: E501
123130
124131
Keyword Args:
125-
value (str):, must be one of ["CREATE_IN_PROGRESS", "CREATE_FAILED", "CREATE_COMPLETE", "ROLLBACK_IN_PROGRESS", "ROLLBACK_FAILED", "ROLLBACK_COMPLETE", "DELETE_IN_PROGRESS", "DELETE_FAILED", "DELETE_COMPLETE", "UPDATE_IN_PROGRESS", "UPDATE_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_COMPLETE", "UPDATE_ROLLBACK_IN_PROGRESS", "UPDATE_ROLLBACK_FAILED", "UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_ROLLBACK_COMPLETE", ] # noqa: E501
132+
value (str):, must be one of ["CREATE_IN_PROGRESS", "CREATE_FAILED", "CREATE_COMPLETE", "IMPORT_IN_PROGRESS", "IMPORT_COMPLETE", "IMPORT_ROLLBACK_IN_PROGRESS", "IMPORT_ROLLBACK_FAILED", "IMPORT_ROLLBACK_COMPLETE", "ROLLBACK_IN_PROGRESS", "ROLLBACK_FAILED", "ROLLBACK_COMPLETE", "DELETE_IN_PROGRESS", "DELETE_FAILED", "DELETE_COMPLETE", "REVIEW_IN_PROGRESS", "UPDATE_IN_PROGRESS", "UPDATE_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_COMPLETE", "UPDATE_FAILED", "UPDATE_ROLLBACK_IN_PROGRESS", "UPDATE_ROLLBACK_FAILED", "UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_ROLLBACK_COMPLETE", ] # noqa: E501
126133
_check_type (bool): if True, values for parameters in openapi_types
127134
will be type checked and a TypeError will be
128135
raised if the wrong type is input.
@@ -213,10 +220,10 @@ def _from_openapi_data(cls, *args, **kwargs):
213220
Note that value can be passed either in args or in kwargs, but not in both.
214221
215222
Args:
216-
args[0] (str):, must be one of ["CREATE_IN_PROGRESS", "CREATE_FAILED", "CREATE_COMPLETE", "ROLLBACK_IN_PROGRESS", "ROLLBACK_FAILED", "ROLLBACK_COMPLETE", "DELETE_IN_PROGRESS", "DELETE_FAILED", "DELETE_COMPLETE", "UPDATE_IN_PROGRESS", "UPDATE_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_COMPLETE", "UPDATE_ROLLBACK_IN_PROGRESS", "UPDATE_ROLLBACK_FAILED", "UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_ROLLBACK_COMPLETE", ] # noqa: E501
223+
args[0] (str):, must be one of ["CREATE_IN_PROGRESS", "CREATE_FAILED", "CREATE_COMPLETE", "IMPORT_IN_PROGRESS", "IMPORT_COMPLETE", "IMPORT_ROLLBACK_IN_PROGRESS", "IMPORT_ROLLBACK_FAILED", "IMPORT_ROLLBACK_COMPLETE", "ROLLBACK_IN_PROGRESS", "ROLLBACK_FAILED", "ROLLBACK_COMPLETE", "DELETE_IN_PROGRESS", "DELETE_FAILED", "DELETE_COMPLETE", "REVIEW_IN_PROGRESS", "UPDATE_IN_PROGRESS", "UPDATE_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_COMPLETE", "UPDATE_FAILED", "UPDATE_ROLLBACK_IN_PROGRESS", "UPDATE_ROLLBACK_FAILED", "UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_ROLLBACK_COMPLETE", ] # noqa: E501
217224
218225
Keyword Args:
219-
value (str):, must be one of ["CREATE_IN_PROGRESS", "CREATE_FAILED", "CREATE_COMPLETE", "ROLLBACK_IN_PROGRESS", "ROLLBACK_FAILED", "ROLLBACK_COMPLETE", "DELETE_IN_PROGRESS", "DELETE_FAILED", "DELETE_COMPLETE", "UPDATE_IN_PROGRESS", "UPDATE_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_COMPLETE", "UPDATE_ROLLBACK_IN_PROGRESS", "UPDATE_ROLLBACK_FAILED", "UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_ROLLBACK_COMPLETE", ] # noqa: E501
226+
value (str):, must be one of ["CREATE_IN_PROGRESS", "CREATE_FAILED", "CREATE_COMPLETE", "IMPORT_IN_PROGRESS", "IMPORT_COMPLETE", "IMPORT_ROLLBACK_IN_PROGRESS", "IMPORT_ROLLBACK_FAILED", "IMPORT_ROLLBACK_COMPLETE", "ROLLBACK_IN_PROGRESS", "ROLLBACK_FAILED", "ROLLBACK_COMPLETE", "DELETE_IN_PROGRESS", "DELETE_FAILED", "DELETE_COMPLETE", "REVIEW_IN_PROGRESS", "UPDATE_IN_PROGRESS", "UPDATE_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_COMPLETE", "UPDATE_FAILED", "UPDATE_ROLLBACK_IN_PROGRESS", "UPDATE_ROLLBACK_FAILED", "UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS", "UPDATE_ROLLBACK_COMPLETE", ] # noqa: E501
220227
_check_type (bool): if True, values for parameters in openapi_types
221228
will be type checked and a TypeError will be
222229
raised if the wrong type is input.

‎api/spec/openapi/ParallelCluster.openapi.yaml

+7
Original file line numberDiff line numberDiff line change
@@ -1673,15 +1673,22 @@ components:
16731673
- CREATE_IN_PROGRESS
16741674
- CREATE_FAILED
16751675
- CREATE_COMPLETE
1676+
- IMPORT_IN_PROGRESS
1677+
- IMPORT_COMPLETE
1678+
- IMPORT_ROLLBACK_IN_PROGRESS
1679+
- IMPORT_ROLLBACK_FAILED
1680+
- IMPORT_ROLLBACK_COMPLETE
16761681
- ROLLBACK_IN_PROGRESS
16771682
- ROLLBACK_FAILED
16781683
- ROLLBACK_COMPLETE
16791684
- DELETE_IN_PROGRESS
16801685
- DELETE_FAILED
16811686
- DELETE_COMPLETE
1687+
- REVIEW_IN_PROGRESS
16821688
- UPDATE_IN_PROGRESS
16831689
- UPDATE_COMPLETE_CLEANUP_IN_PROGRESS
16841690
- UPDATE_COMPLETE
1691+
- UPDATE_FAILED
16851692
- UPDATE_ROLLBACK_IN_PROGRESS
16861693
- UPDATE_ROLLBACK_FAILED
16871694
- UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS

‎api/spec/smithy/model/types/Common.smithy

+7
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,22 @@ string ValidationLevel
4545
{name: "CREATE_IN_PROGRESS", value: "CREATE_IN_PROGRESS"},
4646
{name: "CREATE_FAILED", value: "CREATE_FAILED"},
4747
{name: "CREATE_COMPLETE", value: "CREATE_COMPLETE"},
48+
{name: "IMPORT_IN_PROGRESS", value: "IMPORT_IN_PROGRESS"},
49+
{name: "IMPORT_COMPLETE", value: "IMPORT_COMPLETE"},
50+
{name: "IMPORT_ROLLBACK_IN_PROGRESS", value: "IMPORT_ROLLBACK_IN_PROGRESS"},
51+
{name: "IMPORT_ROLLBACK_FAILED", value: "IMPORT_ROLLBACK_FAILED"},
52+
{name: "IMPORT_ROLLBACK_COMPLETE", value: "IMPORT_ROLLBACK_COMPLETE"},
4853
{name: "ROLLBACK_IN_PROGRESS", value: "ROLLBACK_IN_PROGRESS"},
4954
{name: "ROLLBACK_FAILED", value: "ROLLBACK_FAILED"},
5055
{name: "ROLLBACK_COMPLETE", value: "ROLLBACK_COMPLETE"},
5156
{name: "DELETE_IN_PROGRESS", value: "DELETE_IN_PROGRESS"},
5257
{name: "DELETE_FAILED", value: "DELETE_FAILED"},
5358
{name: "DELETE_COMPLETE", value: "DELETE_COMPLETE"},
59+
{name: "REVIEW_IN_PROGRESS", value: "REVIEW_IN_PROGRESS"},
5460
{name: "UPDATE_IN_PROGRESS", value: "UPDATE_IN_PROGRESS"},
5561
{name: "UPDATE_COMPLETE_CLEANUP_IN_PROGRESS", value: "UPDATE_COMPLETE_CLEANUP_IN_PROGRESS"},
5662
{name: "UPDATE_COMPLETE", value: "UPDATE_COMPLETE"},
63+
{name: "UPDATE_FAILED", value: "UPDATE_FAILED"},
5764
{name: "UPDATE_ROLLBACK_IN_PROGRESS", value: "UPDATE_ROLLBACK_IN_PROGRESS"},
5865
{name: "UPDATE_ROLLBACK_FAILED", value: "UPDATE_ROLLBACK_FAILED"},
5966
{name: "UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS", value: "UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS"},

‎cli/src/pcluster/api/openapi/openapi.yaml

+7
Original file line numberDiff line numberDiff line change
@@ -2017,15 +2017,22 @@ components:
20172017
- CREATE_IN_PROGRESS
20182018
- CREATE_FAILED
20192019
- CREATE_COMPLETE
2020+
- IMPORT_IN_PROGRESS
2021+
- IMPORT_COMPLETE
2022+
- IMPORT_ROLLBACK_IN_PROGRESS
2023+
- IMPORT_ROLLBACK_FAILED
2024+
- IMPORT_ROLLBACK_COMPLETE
20202025
- ROLLBACK_IN_PROGRESS
20212026
- ROLLBACK_FAILED
20222027
- ROLLBACK_COMPLETE
20232028
- DELETE_IN_PROGRESS
20242029
- DELETE_FAILED
20252030
- DELETE_COMPLETE
2031+
- REVIEW_IN_PROGRESS
20262032
- UPDATE_IN_PROGRESS
20272033
- UPDATE_COMPLETE_CLEANUP_IN_PROGRESS
20282034
- UPDATE_COMPLETE
2035+
- UPDATE_FAILED
20292036
- UPDATE_ROLLBACK_IN_PROGRESS
20302037
- UPDATE_ROLLBACK_FAILED
20312038
- UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS

0 commit comments

Comments
 (0)