Skip to content

Commit de1e865

Browse files
committed
Fix linter errors
1 parent 469197f commit de1e865

File tree

2 files changed

+17
-4
lines changed

2 files changed

+17
-4
lines changed

cli/src/pcluster/imagebuilder_utils.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,12 @@ def _expected_inline_policy(account_id: str, partition: str):
140140
{"Action": "ec2:CreateTags", "Resource": f"arn:{partition}:ec2:*::image/*", "Effect": "Allow"},
141141
{"Action": "tag:TagResources", "Resource": "*", "Effect": "Allow"},
142142
{
143-
"Action": ["lambda:DeleteFunction", "lambda:RemovePermission", "lambda:GetFunction", "lambda:GetPolicy"],
143+
"Action": [
144+
"lambda:DeleteFunction",
145+
"lambda:RemovePermission",
146+
"lambda:GetFunction",
147+
"lambda:GetPolicy",
148+
],
144149
"Resource": f"arn:{partition}:lambda:*:{account_id}:function:ParallelClusterImage-*",
145150
"Effect": "Allow",
146151
},

cli/tests/pcluster/cli/test_build_image.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -285,8 +285,16 @@ def test_ensure_default_build_image_stack_cleanup_role_permission_denied(self, a
285285
@pytest.mark.parametrize(
286286
"account_id, partition, actions",
287287
[
288-
("123456789012", "aws", ["lambda:DeleteFunction", "lambda:RemovePermission", "lambda:GetFunction", "lambda:GetPolicy"]),
289-
("000000000000", "aws-us-gov", ["lambda:DeleteFunction", "lambda:RemovePermission", "lambda:GetFunction", "lambda:GetPolicy"]),
288+
(
289+
"123456789012",
290+
"aws",
291+
["lambda:DeleteFunction", "lambda:RemovePermission", "lambda:GetFunction", "lambda:GetPolicy"],
292+
),
293+
(
294+
"000000000000",
295+
"aws-us-gov",
296+
["lambda:DeleteFunction", "lambda:RemovePermission", "lambda:GetFunction", "lambda:GetPolicy"],
297+
),
290298
],
291299
)
292300
def test_expected_inline_policy_dynamic_fields(self, account_id, partition, actions):
@@ -310,7 +318,7 @@ def test_expected_inline_policy_dynamic_fields(self, account_id, partition, acti
310318
if not res == f"arn:{partition}:ec2:*::image/*":
311319
assert f":{account_id}:" in res
312320
if len(actions) != 0:
313-
assert False, f"Actions {actions} are not in the policy"
321+
raise AssertionError(f"Actions {actions} are not in the policy")
314322

315323
def _build_args(self, args):
316324
args = [[k, v] if v is not None else [k] for k, v in args.items()]

0 commit comments

Comments
 (0)