Skip to content

Commit b1714d8

Browse files
UnquietCodesean-smith
authored andcommitted
incorporating reviewer feedback
1 parent 7e7b9b8 commit b1714d8

File tree

1 file changed

+12
-39
lines changed

1 file changed

+12
-39
lines changed

cloudformation/cfncluster.cfn.json

+12-39
Original file line numberDiff line numberDiff line change
@@ -1964,30 +1964,23 @@
19641964
"Properties": {
19651965
"Path": "/",
19661966
"Roles": [
1967-
{
1968-
"Ref": "RootRole"
1969-
}
1967+
{"Fn::If": [
1968+
"UseEC2IAMRole",
1969+
{
1970+
"Ref": "EC2IAMRoleName"
1971+
},
1972+
{
1973+
"Ref": "RootRole"
1974+
}
1975+
]}
19701976
]
19711977
},
1972-
"Condition": "CreateEC2IAMRole",
19731978
"Metadata": {
19741979
"AWS::CloudFormation::Designer": {
19751980
"id": "2522b048-2b7c-44ed-9d35-6cc66069ca5b"
19761981
}
19771982
}
1978-
},
1979-
"NewInstanceProfile": {
1980-
"Type": "AWS::IAM::InstanceProfile",
1981-
"Properties": {
1982-
"Path": "/",
1983-
"Roles": [
1984-
{
1985-
"Ref": "EC2IAMRoleName"
1986-
}
1987-
]
1988-
},
1989-
"Condition": "UseEC2IAMRole"
1990-
},
1983+
},
19911984
"CfnClusterPolicies": {
19921985
"Type": "AWS::IAM::Policy",
19931986
"Properties": {
@@ -2435,17 +2428,7 @@
24352428
false
24362429
]
24372430
},
2438-
"IamInstanceProfile": {
2439-
"Fn::If": [
2440-
"UseEC2IAMRole",
2441-
{
2442-
"Ref": "NewInstanceProfile"
2443-
},
2444-
{
2445-
"Ref": "RootInstanceProfile"
2446-
}
2447-
]
2448-
},
2431+
"IamInstanceProfile": {"Ref": "RootInstanceProfile"},
24492432
"PlacementGroupName": {
24502433
"Fn::If": [
24512434
"UseClusterPlacement",
@@ -3009,17 +2992,7 @@
30092992
"KeyName": {
30102993
"Ref": "KeyName"
30112994
},
3012-
"IamInstanceProfile": {
3013-
"Fn::If": [
3014-
"UseEC2IAMRole",
3015-
{
3016-
"Ref": "NewInstanceProfile"
3017-
},
3018-
{
3019-
"Ref": "RootInstanceProfile"
3020-
}
3021-
]
3022-
},
2995+
"IamInstanceProfile": {"Ref": "RootInstanceProfile"},
30232996
"SpotPrice": {
30242997
"Fn::If": [
30252998
"UseSpotInstances",

0 commit comments

Comments
 (0)