Revert "Add set -e on top of each bash script in cookbooks"

This reverts commit e6e4e95.

Author: demartinofra

recipes/_ganglia_install.rb

@@ -42,7 +42,6 @@
       group 'root'
       cwd Chef::Config[:file_cache_path]
       code <<-GANGLIA
-        set -e
         tar xf #{ganglia_tarball}
         cd monitor-core-#{node['cfncluster']['ganglia']['version']}
         ./bootstrap
@@ -98,7 +97,6 @@
       group 'root'
       cwd Chef::Config[:file_cache_path]
       code <<-GANGLIAWEB
-        set -e
         tar xf #{ganglia_web_tarball}
         cd ganglia-web-#{node['cfncluster']['ganglia']['web_version']}
         make install APACHE_USER=#{node['cfncluster']['ganglia']['apache_user']}
@@ -130,7 +128,6 @@
       group 'root'
       cwd Chef::Config[:file_cache_path]
       code <<-GANGLIALICENSE
-        set -e
         cd monitor-core-#{node['cfncluster']['ganglia']['version']}
         cp -v COPYING #{node['cfncluster']['license_dir']}/ganglia/COPYING
       GANGLIALICENSE

recipes/_master_base_config.rb

@@ -187,7 +187,6 @@
 bash "ssh-keygen" do
   cwd "/home/#{node['cfncluster']['cfn_cluster_user']}"
   code <<-KEYGEN
-    set -e
     su - #{node['cfncluster']['cfn_cluster_user']} -c \"ssh-keygen -q -t rsa -f ~/.ssh/id_rsa -N ''\"
   KEYGEN
   not_if { ::File.exist?("/home/#{node['cfncluster']['cfn_cluster_user']}/.ssh/id_rsa") }
@@ -196,7 +195,6 @@
 bash "copy_and_perms" do
   cwd "/home/#{node['cfncluster']['cfn_cluster_user']}"
   code <<-PERMS
-    set -e
     su - #{node['cfncluster']['cfn_cluster_user']} -c \"cat ~/.ssh/id_rsa.pub >> ~/.ssh/authorized_keys && chmod 0600 ~/.ssh/authorized_keys && touch ~/.ssh/authorized_keys_cluster\"
   PERMS
   not_if { ::File.exist?("/home/#{node['cfncluster']['cfn_cluster_user']}/.ssh/authorized_keys_cluster") }
@@ -205,7 +203,6 @@
 bash "ssh-keyscan" do
   cwd "/home/#{node['cfncluster']['cfn_cluster_user']}"
   code <<-KEYSCAN
-    set -e
     su - #{node['cfncluster']['cfn_cluster_user']} -c \"ssh-keyscan #{node['hostname']} > ~/.ssh/known_hosts && chmod 0600 ~/.ssh/known_hosts\"
   KEYSCAN
   not_if { ::File.exist?("/home/#{node['cfncluster']['cfn_cluster_user']}/.ssh/known_hosts") }

recipes/_master_sge_config.rb

@@ -52,15 +52,13 @@
 
 bash "add_host_as_master" do
   code <<-ADDHOST
-    set -e
     . /opt/sge/default/common/settings.sh
     qconf -as #{node['hostname']}
   ADDHOST
 end
 
 bash "set_accounting_summary" do
   code <<-SETAS
-    set -e
     . /opt/sge/default/common/settings.sh
     TMPFILE=/tmp/pe.txt
     qconf -sp mpi | grep -v 'accounting_summary' > $TMPFILE
@@ -73,7 +71,6 @@
 # Enable non-admin users to force delete a job
 bash "enable_forced_qdel" do
   code <<-ENABLEFORCEDQDEL
-    set -e
     . /opt/sge/default/common/settings.sh
     /opt/sge/util/qconf_add_list_value -mconf qmaster_params ENABLE_FORCED_QDEL global
   ENABLEFORCEDQDEL

recipes/_master_torque_config.rb

@@ -18,7 +18,6 @@
 # Run torque.setup
 bash "run-torque-setup" do
   code <<-SETUPTORQUE
-    set -e
     . /etc/profile.d/torque.sh
     ./torque.setup root
   SETUPTORQUE

recipes/awsbatch_config.rb

@@ -41,7 +41,6 @@
   bash "install aws-parallelcluster-awsbatch-cli" do
     cwd Chef::Config[:file_cache_path]
     code <<-CLI
-      set -e
       source /tmp/proxy.sh
       curl --retry 3 -v -L -o aws-parallelcluster.tgz #{node['cfncluster']['custom_awsbatchcli_package']}
       tar -xzf aws-parallelcluster.tgz

recipes/base_install.rb

@@ -56,7 +56,6 @@
 bash "install awscli" do
   cwd Chef::Config[:file_cache_path]
   code <<-CLI
-    set -e
     curl --retry 5 --retry-delay 5 "https://s3.amazonaws.com/aws-cli/awscli-bundle.zip" -o "awscli-bundle.zip"
     unzip awscli-bundle.zip
     ./awscli-bundle/install -i /usr/local/aws -b /usr/local/bin/aws
@@ -121,13 +120,9 @@
   bash "install aws-parallelcluster-node" do
     cwd Chef::Config[:file_cache_path]
     code <<-NODE
-      set -e
       [[ ":$PATH:" != *":/usr/local/bin:"* ]] && PATH="/usr/local/bin:${PATH}"
       echo "PATH is $PATH"
-      PROXY_FILE=/tmp/proxy.sh
-      if [ -f "$PROXY_FILE" ]; then
-              source $PROXY_FILE
-      fi
+      source /tmp/proxy.sh
       source #{node['cfncluster']['node_virtualenv_path']}/bin/activate
       pip uninstall --yes aws-parallelcluster-node
       curl --retry 3 -v -L -o aws-parallelcluster-node.tgz #{node['cfncluster']['custom_node_package']}

recipes/dcv_config.rb

@@ -44,7 +44,6 @@ def allow_gpu_acceleration
   bash 'Launch X' do
     user 'root'
     code <<-SETUPX
-      set -e
       systemctl set-default graphical.target
       systemctl isolate graphical.target &
     SETUPX

recipes/munge_install.rb

@@ -39,7 +39,6 @@
   group 'root'
   cwd Chef::Config[:file_cache_path]
   code <<-MUNGE
-    set -e
     tar xf #{munge_tarball}
     cd munge-munge-#{node['cfncluster']['munge']['munge_version']}
     ./bootstrap

recipes/sge_install.rb

@@ -120,7 +120,6 @@
     group 'root'
     cwd Chef::Config[:file_cache_path]
     code <<-SGELICENSE
-      set -e
       cd sge-#{node['cfncluster']['sge']['version']}/LICENCES
       cp -v SISSL #{node['cfncluster']['license_dir']}/sge/SISSL
     SGELICENSE

recipes/slurm_install.rb

@@ -68,7 +68,6 @@
     group 'root'
     cwd Chef::Config[:file_cache_path]
     code <<-SLURMLICENSE
-      set -e
       cd slurm-slurm-#{node['cfncluster']['slurm']['version']}
       cp -v COPYING #{node['cfncluster']['license_dir']}/slurm/COPYING
       cp -v DISCLAIMER #{node['cfncluster']['license_dir']}/slurm/DISCLAIMER