use default values if env var is specified but empty (#40)

bwagner5 · jillmon · commit b4f527969897 · 2020-01-03T13:43:26.000-06:00
diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -108,7 +108,9 @@ func ParseCliArgs() Config {
 // Get env var or default
 func getEnv(key string, fallback string) string {
 	if value, ok := os.LookupEnv(key); ok {
-		return value
+		if value != "" {
+			return value
+		}
 	}
 	return fallback
 }

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,9 @@ func ParseCliArgs() Config {`
`108`	`108`	`// Get env var or default`
`109`	`109`	`func getEnv(key string, fallback string) string {`
`110`	`110`	`if value, ok := os.LookupEnv(key); ok {`
`111`		`- return value`
	`111`	`+ if value != "" {`
	`112`	`+ return value`
	`113`	`+ }`
`112`	`114`	`}`
`113`	`115`	`return fallback`
`114`	`116`	`}`