Skip to content

Commit 284eea0

Browse files
authoredJan 8, 2025··
Check reason string in MQTT5 samples (#772)
1 parent 602121d commit 284eea0

File tree

2 files changed

+23
-20
lines changed

2 files changed

+23
-20
lines changed
 

‎samples/mqtt5/mqtt5_pubsub/main.cpp

+11-11
Original file line numberDiff line numberDiff line change
@@ -141,11 +141,11 @@ int main(int argc, char *argv[])
141141
{
142142
if (reasonCode > Mqtt5::SubAckReasonCode::AWS_MQTT5_SARC_UNSPECIFIED_ERROR)
143143
{
144-
fprintf(
145-
stdout,
146-
"MQTT5 Client Subscription failed with server error code: (%d)%s\n",
147-
reasonCode,
148-
suback->getReasonString()->c_str());
144+
fprintf(stdout, "MQTT5 Client Subscription failed with server error code: %d\n", reasonCode);
145+
if (suback->getReasonString().has_value())
146+
{
147+
fprintf(stdout, "\tError reason string: %s\n", suback->getReasonString()->c_str());
148+
}
149149
subscribeSuccess.set_value(false);
150150
return;
151151
}
@@ -185,13 +185,13 @@ int main(int argc, char *argv[])
185185
}
186186
else
187187
{
188-
fprintf(
189-
stdout,
190-
"PubACK reason code: %d : %s\n",
191-
puback->getReasonCode(),
192-
puback->getReasonString()->c_str());
188+
fprintf(stdout, "PubACK reason code: %d\n", puback->getReasonCode());
189+
if (puback->getReasonString().has_value())
190+
{
191+
fprintf(stdout, "\nError reason string: %s\n", puback->getReasonString()->c_str());
192+
}
193193
}
194-
};
194+
}
195195
};
196196

197197
uint32_t publishedCount = 0;

‎samples/mqtt5/mqtt5_shared_subscription/main.cpp

+12-9
Original file line numberDiff line numberDiff line change
@@ -246,11 +246,11 @@ int main(int argc, char *argv[])
246246
{
247247
if (reasonCode >= Mqtt5::SubAckReasonCode::AWS_MQTT5_SARC_UNSPECIFIED_ERROR)
248248
{
249-
fprintf(
250-
stdout,
251-
"MQTT5 Client Subscription failed with server error code: (%d)%s\n",
252-
reasonCode,
253-
suback->getReasonString()->c_str());
249+
fprintf(stdout, "MQTT5 Client Subscription failed with server error code: %d\n", reasonCode);
250+
if (suback->getReasonString().has_value())
251+
{
252+
fprintf(stdout, "\tError reason string: %s\n", suback->getReasonString()->c_str());
253+
}
254254
subscribeSuccess.set_value(reasonCode);
255255
return;
256256
}
@@ -331,12 +331,15 @@ int main(int argc, char *argv[])
331331
{
332332
fprintf(
333333
stdout,
334-
"[%s] Publish failed. PubACK reason code: %d : %s\n",
334+
"[%s] Publish failed. PubACK reason code: %d\n",
335335
publisher->name.c_str(),
336-
puback->getReasonCode(),
337-
puback->getReasonString()->c_str());
336+
puback->getReasonCode());
337+
if (puback->getReasonString().has_value())
338+
{
339+
fprintf(stdout, "\nError reason string: %s\n", puback->getReasonString()->c_str());
340+
}
338341
}
339-
};
342+
}
340343
};
341344

342345
uint64_t publishedCount = 0;

0 commit comments

Comments
 (0)
Please sign in to comment.