-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(imagebuilder-alpha): add support for Container Recipe Construct #36091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
039ee95 to
b4532cb
Compare
Pull request has been modified.
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
b4532cb to
ed73d68
Compare
Pull request has been modified.
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
ed73d68 to
558d237
Compare
Pull request has been modified.
558d237 to
d811b28
Compare
4bb2d3a to
1620275
Compare
tarunb12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replying to comments
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/test/base-image.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts
Outdated
Show resolved
Hide resolved
1620275 to
2a5ad9d
Compare
2a5ad9d to
3e832ba
Compare
Pull request has been modified.
packages/@aws-cdk/aws-imagebuilder-alpha/test/integ.default-parameters.container-recipe.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/test/integ.all-parameters.container-recipe.ts
Show resolved
Hide resolved
Pull request has been modified.
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
kumsmrit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing all the comments.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue
aws/aws-cdk-rfcs#789
Reason for this change
This change adds a new alpha module for EC2 Image Builder L2 Constructs (@aws-cdk/aws-imagebuilder-alpha), as outlined in aws/aws-cdk-rfcs#789. This PR specifically implements the ContainerRecipe construct.
Description of changes
This change implements the
ContainerRecipeconstruct, which is a higher-level construct of CfnContainerRecipe.Example
Describe any new or updated permissions being added
N/A - new L2 construct in alpha module
Description of how you validated changes
Validated with unit tests and integration tests. Manually verified generated CFN templates as well.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license