- I added tests to new or existing code
- I removed hardcoded strings and used our
i18nsolution instead (see here) - I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
- I checked that infrastructure/update_infrastructure.sh runs without any error
- I checked that
npm run buildbuilds without any error - I checked that clusters are listed correctly
- I checked that a new cluster can be created (config is produced and dry run passes)
- I checked that login and logout work as expected
In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.