Skip to content

Adding support for p5.48xlarge and p4de.24xlarge instance types and Fix for FsX monitoring #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Adding support for p5.48xlarge and p4de.24xlarge instance types and Fix for FsX monitoring #31

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4748c4d
Adding support for p5.48xlarge and p4de.24xlarge
gallanik Dec 14, 2023
e90d3bb
Update FsX parameter name in config
gallanik Dec 14, 2023
8836ded
Update post-install.sh
gallanik Jan 15, 2024
233f9f5
Update post-install.sh
gallanik Jan 16, 2024
5c27c1a
Update post-install.sh
gallanik Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parallelcluster-setup/install-monitoring.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ case "${cfn_node_type}" in

#cfn_efs=$(cat /etc/chef/dna.json | grep \"cfn_efs\" | awk '{print $2}' | sed "s/\",//g;s/\"//g")
#cfn_cluster_cw_logging_enabled=$(cat /etc/chef/dna.json | grep \"cfn_cluster_cw_logging_enabled\" | awk '{print $2}' | sed "s/\",//g;s/\"//g")
cfn_fsx_fs_id=$(cat /etc/chef/dna.json | grep \"cfn_fsx_fs_id\" | awk '{print $2}' | sed "s/\",//g;s/\"//g")
cfn_fsx_fs_id=$(cat /etc/chef/dna.json | grep \"fsx_fs_ids\" | awk '{print $2}' | sed "s/\",//g;s/\"//g")
master_instance_id=$(ec2-metadata -i | awk '{print $2}')
cfn_max_queue_size=$(aws cloudformation describe-stacks --stack-name $stack_name --region $cfn_region | jq -r '.Stacks[0].Parameters | map(select(.ParameterKey == "MaxSize"))[0].ParameterValue')
s3_bucket=$(echo $cfn_postinstall | sed "s/s3:\/\///g;s/\/.*//")
Expand Down
2 changes: 1 addition & 1 deletion post-install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ monitoring_dir_name=aws-parallelcluster-monitoring
monitoring_tarball="${monitoring_dir_name}.tar.gz"

#get GitHub repo to clone and the installation script
monitoring_url=https://github.com/aws-samples/aws-parallelcluster-monitoring/archive/refs/tags/${version}.tar.gz
monitoring_url=https://github.com/gallanik/aws-parallelcluster-monitoring/archive/refs/tags/${version}.tar.gz
Copy link

@sean-smith sean-smith Jan 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this.

setup_command=install-monitoring.sh
monitoring_home="/home/${cfn_cluster_user}/${monitoring_dir_name}"

Expand Down
2 changes: 2 additions & 0 deletions prometheus/prometheus.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ scrape_configs:
- p3.16xlarge
- p3dn.24xlarge
- p4d.24xlarge
- p4de.24xlarge
- p5.48xlarge
- g3s.xlarge
- g3.4xlarge
- g3.8xlarge
Expand Down