Skip to content

Commit 7cc17d3

Browse files
ack-botack-bot
authored
Update to ACK runtime v0.41.0, code-generator v0.41.0 (#285)
### Update to ACK runtime `v0.41.0`, code-generator `v0.41.0` ---------- * ACK code-generator `v0.41.0` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.41.0) * ACK runtime `v0.41.0` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.41.0) ---------- NOTE: This PR increments the release version of service controller from `v1.2.13` to `v1.2.14` Once this PR is merged, release `v1.2.14` will be automatically created for `sagemaker-controller` **Please close this PR, if you do not want the new patch release for `sagemaker-controller`** ---------- #### stdout for `make build-controller`: ``` building ack-generate ... ok. ==== building sagemaker-controller ==== Copying common custom resource definitions into sagemaker Building Kubernetes API objects for sagemaker Generating deepcopy code for sagemaker Generating custom resource definitions for sagemaker Building service controller for sagemaker Generating RBAC manifests for sagemaker Running gofmt against generated code for sagemaker Updating additional GitHub repository maintenance files ==== building sagemaker-controller release artifacts ==== Building release artifacts for sagemaker-v1.2.14 Generating common custom resource definitions Generating custom resource definitions for sagemaker Generating RBAC manifests for sagemaker ``` ---------- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 68e13e5 commit 7cc17d3

File tree

110 files changed

+635
-1780
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

110 files changed

+635
-1780
lines changed

‎OWNERS

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
# See the OWNERS docs at https://go.k8s.io/owners
22

33
approvers:
4-
- core-ack-team
5-
- service-team
4+
- core-ack-team

‎OWNERS_ALIASES

+11-14
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,16 @@
11
# See the OWNERS docs at https://go.k8s.io/owners#owners_aliases
22

33
aliases:
4-
# Always allow the core ACK maintainers to have access to your repository
54
core-ack-team:
6-
- jaypipes
7-
- mhausenblas
85
- a-hilaly
9-
- RedbackThomson
10-
- vijtrip2
11-
- jljaco
12-
# TODO: Add your team members to your team controller alias
13-
service-team:
14-
- ananth102
15-
- jsitu777
16-
- surajkota
17-
- ryansteakley
18-
- rd-pong
19-
- suryans-commit
6+
- jlbutler
7+
- michaelhtm
8+
- TiberiuGC
9+
- rushmash91
10+
# emeritus-core-ack-team:
11+
# - jaypipes
12+
# - jljaco
13+
# - mhausenblas
14+
# - RedbackThomson
15+
# - vijtrip2
16+
# - ivelichkovich

‎apis/v1alpha1/ack-generate-metadata.yaml

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
ack_generate_info:
2-
build_date: "2024-08-29T17:06:56Z"
3-
build_hash: f8f98563404066ac3340db0a049d2e530e5c51cc
4-
go_version: go1.22.5
5-
version: v0.38.1
2+
build_date: "2025-01-23T02:33:10Z"
3+
build_hash: 2442aa071c05fcdf54841e63abd5f91d1951e152
4+
go_version: go1.23.5
5+
version: v0.41.0
66
api_directory_checksum: 476c2a15949ae95e3cefcc07b7eb39de6cd7548b
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.50.15

‎config/controller/deployment.yaml

+4
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ spec:
4141
- "$(LEADER_ELECTION_NAMESPACE)"
4242
- --reconcile-default-max-concurrent-syncs
4343
- "$(RECONCILE_DEFAULT_MAX_CONCURRENT_SYNCS)"
44+
- --feature-gates
45+
- "$(FEATURE_GATES)"
4446
image: controller:latest
4547
name: controller
4648
ports:
@@ -76,6 +78,8 @@ spec:
7678
value: "ack-system"
7779
- name: "RECONCILE_DEFAULT_MAX_CONCURRENT_SYNCS"
7880
value: "1"
81+
- name: "FEATURE_GATES"
82+
value: ""
7983
securityContext:
8084
allowPrivilegeEscalation: false
8185
privileged: false

‎config/controller/kustomization.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ kind: Kustomization
66
images:
77
- name: controller
88
newName: public.ecr.aws/aws-controllers-k8s/sagemaker-controller
9-
newTag: 1.2.13
9+
newTag: 1.2.14

‎config/crd/bases/sagemaker.services.k8s.aws_apps.yaml

+1-5
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
33
kind: CustomResourceDefinition
44
metadata:
55
annotations:
6-
controller-gen.kubebuilder.io/version: v0.14.0
6+
controller-gen.kubebuilder.io/version: v0.16.2
77
name: apps.sagemaker.services.k8s.aws
88
spec:
99
group: sagemaker.services.k8s.aws
@@ -57,7 +57,6 @@ spec:
5757
The instance type and the Amazon Resource Name (ARN) of the SageMaker image
5858
created on the instance.
5959
60-
6160
The value of InstanceType passed as part of the ResourceSpec in the CreateApp
6261
call overrides the value passed as part of the ResourceSpec configured for
6362
the user profile or the domain. If InstanceType is not specified in any of
@@ -84,13 +83,11 @@ spec:
8483
A tag object that consists of a key and an optional value, used to manage
8584
metadata for SageMaker Amazon Web Services resources.
8685
87-
8886
You can add tags to notebook instances, training jobs, hyperparameter tuning
8987
jobs, batch transform jobs, models, labeling jobs, work teams, endpoint configurations,
9088
and endpoints. For more information on adding tags to SageMaker resources,
9189
see AddTags (https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_AddTags.html).
9290
93-
9491
For more information on adding metadata to your Amazon Web Services resources
9592
with tagging, see Tagging Amazon Web Services resources (https://docs.aws.amazon.com/general/latest/gr/aws_tagging.html).
9693
For advice on best practices for managing Amazon Web Services resources with
@@ -129,7 +126,6 @@ spec:
129126
when it has verified that an "adopted" resource (a resource where the
130127
ARN annotation was set by the Kubernetes user on the CR) exists and
131128
matches the supplied CR's Spec field values.
132-
TODO(vijat@): Find a better strategy for resources that do not have ARN in CreateOutputResponse
133129
https://github.com/aws/aws-controllers-k8s/issues/270
134130
type: string
135131
ownerAccountID:

‎config/crd/bases/sagemaker.services.k8s.aws_dataqualityjobdefinitions.yaml

+1-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
33
kind: CustomResourceDefinition
44
metadata:
55
annotations:
6-
controller-gen.kubebuilder.io/version: v0.14.0
6+
controller-gen.kubebuilder.io/version: v0.16.2
77
name: dataqualityjobdefinitions.sagemaker.services.k8s.aws
88
spec:
99
group: sagemaker.services.k8s.aws
@@ -208,13 +208,11 @@ spec:
208208
A tag object that consists of a key and an optional value, used to manage
209209
metadata for SageMaker Amazon Web Services resources.
210210
211-
212211
You can add tags to notebook instances, training jobs, hyperparameter tuning
213212
jobs, batch transform jobs, models, labeling jobs, work teams, endpoint configurations,
214213
and endpoints. For more information on adding tags to SageMaker resources,
215214
see AddTags (https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_AddTags.html).
216215
217-
218216
For more information on adding metadata to your Amazon Web Services resources
219217
with tagging, see Tagging Amazon Web Services resources (https://docs.aws.amazon.com/general/latest/gr/aws_tagging.html).
220218
For advice on best practices for managing Amazon Web Services resources with
@@ -253,7 +251,6 @@ spec:
253251
when it has verified that an "adopted" resource (a resource where the
254252
ARN annotation was set by the Kubernetes user on the CR) exists and
255253
matches the supplied CR's Spec field values.
256-
TODO(vijat@): Find a better strategy for resources that do not have ARN in CreateOutputResponse
257254
https://github.com/aws/aws-controllers-k8s/issues/270
258255
type: string
259256
ownerAccountID:

‎config/crd/bases/sagemaker.services.k8s.aws_domains.yaml

+1-9
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
33
kind: CustomResourceDefinition
44
metadata:
55
annotations:
6-
controller-gen.kubebuilder.io/version: v0.14.0
6+
controller-gen.kubebuilder.io/version: v0.16.2
77
name: domains.sagemaker.services.k8s.aws
88
spec:
99
group: sagemaker.services.k8s.aws
@@ -50,11 +50,9 @@ spec:
5050
description: |-
5151
Specifies the VPC used for non-EFS traffic. The default value is PublicInternetOnly.
5252
53-
5453
* PublicInternetOnly - Non-EFS traffic is through a VPC managed by Amazon
5554
SageMaker, which allows direct internet access
5655
57-
5856
* VpcOnly - All traffic is through the specified VPC and subnets
5957
type: string
6058
appSecurityGroupManagement:
@@ -74,7 +72,6 @@ spec:
7472
The default settings to use to create a user profile when UserSettings isn't
7573
specified in the call to the CreateUserProfile API.
7674
77-
7875
SecurityGroups is aggregated when specified in both calls. For all other
7976
settings in UserSettings, the values specified in CreateUserProfile take
8077
precedence over those specified in CreateDomain.
@@ -83,7 +80,6 @@ spec:
8380
description: |-
8481
The Code Editor application settings.
8582
86-
8783
For more information about Code Editor, see Get started with Code Editor
8884
in Amazon SageMaker (https://docs.aws.amazon.com/sagemaker/latest/dg/code-editor.html).
8985
properties:
@@ -381,21 +377,18 @@ spec:
381377
value. Tag keys must be unique per resource. Tags are searchable using the
382378
Search API.
383379
384-
385380
Tags that you specify for the Domain are also added to all Apps that the
386381
Domain launches.
387382
items:
388383
description: |-
389384
A tag object that consists of a key and an optional value, used to manage
390385
metadata for SageMaker Amazon Web Services resources.
391386
392-
393387
You can add tags to notebook instances, training jobs, hyperparameter tuning
394388
jobs, batch transform jobs, models, labeling jobs, work teams, endpoint configurations,
395389
and endpoints. For more information on adding tags to SageMaker resources,
396390
see AddTags (https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_AddTags.html).
397391
398-
399392
For more information on adding metadata to your Amazon Web Services resources
400393
with tagging, see Tagging Amazon Web Services resources (https://docs.aws.amazon.com/general/latest/gr/aws_tagging.html).
401394
For advice on best practices for managing Amazon Web Services resources with
@@ -437,7 +430,6 @@ spec:
437430
when it has verified that an "adopted" resource (a resource where the
438431
ARN annotation was set by the Kubernetes user on the CR) exists and
439432
matches the supplied CR's Spec field values.
440-
TODO(vijat@): Find a better strategy for resources that do not have ARN in CreateOutputResponse
441433
https://github.com/aws/aws-controllers-k8s/issues/270
442434
type: string
443435
ownerAccountID:

‎config/crd/bases/sagemaker.services.k8s.aws_endpointconfigs.yaml

+1-14
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
33
kind: CustomResourceDefinition
44
metadata:
55
annotations:
6-
controller-gen.kubebuilder.io/version: v0.14.0
6+
controller-gen.kubebuilder.io/version: v0.16.2
77
name: endpointconfigs.sagemaker.services.k8s.aws
88
spec:
99
group: sagemaker.services.k8s.aws
@@ -135,7 +135,6 @@ spec:
135135
to perform actions on your behalf. For more information, see SageMaker Roles
136136
(https://docs.aws.amazon.com/sagemaker/latest/dg/sagemaker-roles.html).
137137
138-
139138
To be able to pass this role to Amazon SageMaker, the caller of this action
140139
must have the iam:PassRole permission.
141140
type: string
@@ -145,28 +144,21 @@ spec:
145144
key that SageMaker uses to encrypt data on the storage volume attached to
146145
the ML compute instance that hosts the endpoint.
147146
148-
149147
The KmsKeyId can be any of the following formats:
150148
151-
152149
* Key ID: 1234abcd-12ab-34cd-56ef-1234567890ab
153150
154-
155151
* Key ARN: arn:aws:kms:us-west-2:111122223333:key/1234abcd-12ab-34cd-56ef-1234567890ab
156152
157-
158153
* Alias name: alias/ExampleAlias
159154
160-
161155
* Alias name ARN: arn:aws:kms:us-west-2:111122223333:alias/ExampleAlias
162156
163-
164157
The KMS key policy must grant permission to the IAM role that you specify
165158
in your CreateEndpoint, UpdateEndpoint requests. For more information, refer
166159
to the Amazon Web Services Key Management Service section Using Key Policies
167160
in Amazon Web Services KMS (https://docs.aws.amazon.com/kms/latest/developerguide/key-policies.html)
168161
169-
170162
Certain Nitro-based instances include local storage, dependent on the instance
171163
type. Local storage volumes are encrypted using a hardware module on the
172164
instance. You can't request a KmsKeyId when using an instance type with local
@@ -176,11 +168,9 @@ spec:
176168
using any nitro-based instances with local storage, the call to CreateEndpointConfig
177169
fails.
178170
179-
180171
For a list of instance types that support local instance storage, see Instance
181172
Store Volumes (https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/InstanceStorage.html#instance-store-volumes).
182173
183-
184174
For more information about local instance storage encryption, see SSD Instance
185175
Store Volumes (https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ssd-instance-store.html).
186176
type: string
@@ -278,13 +268,11 @@ spec:
278268
A tag object that consists of a key and an optional value, used to manage
279269
metadata for SageMaker Amazon Web Services resources.
280270
281-
282271
You can add tags to notebook instances, training jobs, hyperparameter tuning
283272
jobs, batch transform jobs, models, labeling jobs, work teams, endpoint configurations,
284273
and endpoints. For more information on adding tags to SageMaker resources,
285274
see AddTags (https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_AddTags.html).
286275
287-
288276
For more information on adding metadata to your Amazon Web Services resources
289277
with tagging, see Tagging Amazon Web Services resources (https://docs.aws.amazon.com/general/latest/gr/aws_tagging.html).
290278
For advice on best practices for managing Amazon Web Services resources with
@@ -334,7 +322,6 @@ spec:
334322
when it has verified that an "adopted" resource (a resource where the
335323
ARN annotation was set by the Kubernetes user on the CR) exists and
336324
matches the supplied CR's Spec field values.
337-
TODO(vijat@): Find a better strategy for resources that do not have ARN in CreateOutputResponse
338325
https://github.com/aws/aws-controllers-k8s/issues/270
339326
type: string
340327
ownerAccountID:

0 commit comments

Comments
 (0)