Skip to content

Commit 9adb770

Browse files
authored
bring controller to rt 0.20.1 and sdk 1.44.93 (#89)
The S3 controller was not successfully being generated with ACK runtime v0.20.1. An error was being thrown during deepcopy-gen. Turns out that aws-sdk-go v1.44.93, which was brought in because it is used for latest code-generator, added a few fields to the S3 Bucket. One of these fields is `NotificationConfiguration.EventBridgeConfiguration` and it is an empty struct with no fields. Looks like S3 team just added it into the API model without finishing the thought... anyway, ignoring this field in the generator.yaml file enabled the code-generator to successfully complete. Signed-off-by: Jay Pipes <[email protected]> Issue aws-controllers-k8s/community#1475 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 01c6f0a commit 9adb770

19 files changed

+351
-139
lines changed
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
ack_generate_info:
2-
build_date: "2022-09-06T12:50:12Z"
3-
build_hash: 585f06bbd6d4cc1b738acb85901e7a009bf452c7
4-
go_version: go1.17.5
5-
version: v0.20.0
6-
api_directory_checksum: 129f62379684f764be26baaa8e217e0c431281e5
2+
build_date: "2022-11-11T15:38:14Z"
3+
build_hash: 18745aa8d1126566776a4748c403ae891b889e9c
4+
go_version: go1.18.1
5+
version: v0.20.1-7-g18745aa
6+
api_directory_checksum: fba60a852c47b24ee53e1f852250927612ea0bb1
77
api_version: v1alpha1
8-
aws_sdk_go_version: v1.42.0
8+
aws_sdk_go_version: v1.44.93
99
generator_config_info:
10-
file_checksum: c8b1db51c97c92fd2a6929e4792d54f1a9cb603d
10+
file_checksum: 4faed1acfe4aed4d9839e38c50b1c7ce1064bab2
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

apis/v1alpha1/bucket.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/v1alpha1/enums.go

Lines changed: 40 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/v1alpha1/generator.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ ignore:
88
field_paths:
99
# We cannot support MFA, so if it is set we cannot unset
1010
- "VersioningConfiguration.MFADelete"
11+
# This subfield struct has no members...
12+
- "NotificationConfiguration.EventBridgeConfiguration"
1113
resources:
1214
Bucket:
1315
fields:

apis/v1alpha1/types.go

Lines changed: 48 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/v1alpha1/zz_generated.deepcopy.go

Lines changed: 35 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)