fix: missing elevated card shadow on dark mode #6185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f3f4a52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dindjarinjs
reviewed
Nov 21, 2024
jordanvn
reviewed
Nov 26, 2024
| shadow: { | ||
| primary: { value: 'hsla(100, 100%, 100%, 0.25)' }, | ||
| secondary: { value: 'hsla(100, 100%, 100%, 0.15)' }, | ||
| tertiary: { value: 'hsla(100, 100%, 100%, 0.05)' }, |
There was a problem hiding this comment.
Nit: Is this tertiary value being used anywhere besides the slider? The alpha of 0.05 makes sense to match the light mode counterpart, but it's so subtle in dark mode that I can't even see it. Would it make sense to consider increasing the tertiary alpha value for dark mode?
jordanvn
approved these changes
Nov 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change fixes missing box shadows on the elevated variation of the
Cardcomponent. This is because dark mode shadow colors are not defined so it defaults to the light mode shadows, which are extremely difficult to spot in dark mode.This change also visually changes/affects the dark mode versions of other components that use box shadows in general:
Authenticator,Menu, andSlider Field.Issue #, if available
Fixes #5893.
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addeddocs,e2e,examples, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.