Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(file-uploader): fix duplicate upload requests #5818

Merged
merged 6 commits into from
Sep 21, 2024

Conversation

calebpollman
Copy link
Member

@calebpollman calebpollman commented Sep 20, 2024

Description of changes

Issue #, if available

Fixes #5817

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@calebpollman calebpollman requested a review from a team as a code owner September 20, 2024 20:17
Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: 472642d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/ui-react-storage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@calebpollman calebpollman changed the title [WIP] fix(file-uploader): fix duplicate upload requests fix(file-uploader): fix duplicate upload requests Sep 20, 2024
Copy link
Contributor

@reesscot reesscot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went over this PR on a call, changes make sense to me.

@calebpollman calebpollman merged commit 0d50470 into main Sep 21, 2024
34 checks passed
@calebpollman calebpollman deleted the file-uploader/fix-duplicate-upload-requests branch September 21, 2024 00:09
@github-actions github-actions bot mentioned this pull request Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileUploader is triggering 2 uploads to s3 when using ProcessFile prop
3 participants