Skip to content

Conversation

@frichtarik
Copy link
Contributor

@frichtarik frichtarik commented Jun 4, 2025

Which issue(s) does this change fix?

#109

Description

adding support for native installer to work with linux arm64 packages.
added version limit for arm to >=1.104.0 as that's the first version for which this particular package was published

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 License.

@frichtarik frichtarik requested a review from a team as a code owner June 4, 2025 21:52
@frichtarik
Copy link
Contributor Author

Sorry for the direct mentions but i see no other channel to get reviews for this PR, seeing the other PRs unnoticed for many months. I've found your handles as last active approvers on this repo.
Feel free to invite other relevant members of the organization, if you've moved to a different projects.
Thank you in advance.

@samson-keung @GavinZZ @aaythapa

@reedham-aws
Copy link

Thank you for your contribution! The changes look solid, but I don't quite understand why the version limit is >=1.104. Would you mind explaining to me what you mean by 'the first version for which this particular package was published'?

@frichtarik
Copy link
Contributor Author

frichtarik commented Sep 3, 2025

@reedham-aws sure thing
if you look at assets in https://github.com/aws/aws-sam-cli/releases/tag/v1.103.0
there is no linux arm package, only x64

the release workflow started to generate those since 1.104.0 included, so the action would fail on older sam versions, this way the user gets at least some info why

Copy link

@valerena valerena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution! I added a couple of small comments, and one supporting a previous comment from @reedham-aws . Ideally we don't duplicate the entire suite of tests for a single change in the middle.

@frichtarik frichtarik requested a review from valerena September 12, 2025 14:30
Copy link

@roger-zhangg roger-zhangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@roger-zhangg roger-zhangg merged commit c71dd89 into aws-actions:main Oct 9, 2025
31 checks passed
@frichtarik frichtarik deleted the arm-installer branch October 17, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants