Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments 04-running #6

Open
5 of 7 tasks
katilp opened this issue Feb 15, 2020 · 0 comments
Open
5 of 7 tasks

Comments 04-running #6

katilp opened this issue Feb 15, 2020 · 0 comments

Comments

@katilp
Copy link

katilp commented Feb 15, 2020

  • fix link https://awesome-workshop.github.io/continuous-integration-deployment-gitlab/14-the-spy-game/index.html to https://awesome-workshop.github.io/continuous-integration-deployment-gitlab/12-the-spy-game/index.html

  • Is kinit needed in this case? It is good to explain in any case, but if not necessary for this job you could say it for the sake of clarity. It is implicit in what you say about eos but would not harm to say it explicitly. (Reading the instructions I ended up adding the variables but forgot to add the corresponding line to .yml ...)

  • "You cannot write into the artifact directory in one of the following steps." -> "You cannot write into the artifact directory in any of the following steps."?

  • You may want to remind the user how to run only the second step. You explain the reason well at the start "However, imagine that you would like to run test jobs on more than one file and to speed things up do this in parallel. This would mean that you would have to compile the code N times, which is a waste of resources and time. " but I had forgotten that by the end of the page. Maybe just add a phrase or an example on how to do this in parallel in case of several files at the end.

  • I had git cms-addpkg PhysicsTools/PatExamples as a leftover from the previous lesson. Is it needed? If not, you could instruct to remove it as the compilation takes time.

  • the job runs nicely, but gives an error:
    ls -l myZPeak.root
    4337 ls: cannot access myZPeak.root: No such file or directory
    4340 ERROR: Job failed: exit code 1
    I think of being in the right directory, probably I'm wrong...

  • Would it make sense to get the root file out as an artifact?

clelange added a commit that referenced this issue Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant