Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for $string* #63

Closed
ruppde opened this issue Oct 3, 2023 · 2 comments · Fixed by avast/yls#138
Closed

Add support for $string* #63

ruppde opened this issue Oct 3, 2023 · 2 comments · Fixed by avast/yls#138
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ruppde
Copy link
Contributor

ruppde commented Oct 3, 2023

Hello,

yari doesn't support $string* matches in hoovering over conditions. Best way would probably to just show a summary, e.g.:

  • No match
  • Which ones of $string* matched
@ruppde
Copy link
Contributor Author

ruppde commented Oct 3, 2023

Cheap double win would be to enable the hoovering as in the strings section:

  1. Possibility to check each element of $string*
  2. No need to jump from string to the condition section to check a string or regex

Bonus feature: Visually mark all matching strings in the strings section:

@MatejKastak
Copy link
Member

Nice suggestions! This however is not supported in YARI, yet.

But you can try to at least get if the whole expression works if you select the parts of the condition.

image

@MatejKastak MatejKastak added enhancement New feature or request help wanted Extra attention is needed labels Oct 3, 2023
ruppde added a commit to ruppde/yls that referenced this issue Oct 6, 2023
add hover in string section

fix avast/yari#63
MatejKastak pushed a commit to ruppde/yls that referenced this issue Oct 23, 2023
add hover in string section

fix avast/yari#63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Development

Successfully merging a pull request may close this issue.

2 participants