Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for entrypoint and filesize #11

Merged

Conversation

MatejKastak
Copy link
Member

Enable this in complex expressions. This does not work in regular eval because both are represented as u64 and YrValue::Integer has i64.

This might result in losing some information if we just convert it from u64 to i64. We will have to come back to this.

@MatejKastak MatejKastak self-assigned this Sep 23, 2022
@MatejKastak MatejKastak linked an issue Sep 23, 2022 that may be closed by this pull request
Enable this in complex expressions. This does not work in regular eval
because both are represented as `u64` and `YrValue::Integer` has `i64`.

This might result in losing some information if we just convert it from
u64 to i64. We will have to come back to this.
@MatejKastak MatejKastak force-pushed the 10-add-support-for-filesize-and-similar-expressions branch from 5814c79 to 051129f Compare September 23, 2022 17:04
Copy link
Contributor

@tomaskender tomaskender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatejKastak MatejKastak merged commit 07c7052 into master Sep 26, 2022
@MatejKastak MatejKastak deleted the 10-add-support-for-filesize-and-similar-expressions branch September 26, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add support for filesize and similar expressions
2 participants