don't use pseudofunctional paradigma in non-functional code;)

Author: Jan Seidl

retry.go

@@ -74,17 +74,10 @@ func RetryCustom(retryableFunction Retryable, onRetryFunction OnRetry, opts Retr
 type errorLog []error
 
 func (log errorLog) String() string {
-	i := 0
-	return strings.Join(log.Map(func(err error) string {
-		i++
-		return fmt.Sprintf("#%d: %s", i, err.Error())
-	}), "\n")
-}
-
-func (vs errorLog) Map(f func(error) string) []string {
-	vsm := make([]string, len(vs))
-	for i, v := range vs {
-		vsm[i] = f(v)
+	logWithNumber := make([]string, len(log))
+	for i, l := range log {
+		logWithNumber[i] = fmt.Sprintf("#%d: %s", i+1, l.Error())
 	}
-	return vsm
+
+	return strings.Join(logWithNumber, "\n")
 }

retry_test.go

@@ -15,7 +15,19 @@ func TestCustom(t *testing.T) {
 		NewRetryOpts().Units(time.Nanosecond),
 	)
 	assert.Error(t, err)
-	t.Log(err)
+
+	expectedErrorFormat := `All (10) retries fail:
+#1: test
+#2: test
+#3: test
+#4: test
+#5: test
+#6: test
+#7: test
+#8: test
+#9: test
+#10: test`
+	assert.Equal(t, expectedErrorFormat, err.Error(), "retry error format")
 	assert.Equal(t, uint(45), retrySum, "right count of retry")
 
 	retrySum = 0