Skip to content

Commit 7c3b292

Browse files
authored
Merge pull request #684 from avaje/feature/support-valhalla-build
Add support for building against Valhalla EA
2 parents 1560881 + a3c0f92 commit 7c3b292

File tree

13 files changed

+94
-7
lines changed

13 files changed

+94
-7
lines changed

.github/workflows/valhalla-ea.yml

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
2+
name: Valhalla EA
3+
4+
on:
5+
workflow_dispatch:
6+
# push:
7+
# pull_request:
8+
schedule:
9+
- cron: '39 1 * * 1,3,5'
10+
11+
jobs:
12+
build:
13+
14+
runs-on: ${{ matrix.os }}
15+
permissions:
16+
contents: read
17+
packages: write
18+
strategy:
19+
fail-fast: false
20+
matrix:
21+
java_version: [valhalla]
22+
os: [ubuntu-latest]
23+
24+
steps:
25+
- uses: actions/checkout@v4
26+
- name: Set up Java
27+
uses: oracle-actions/setup-java@v1
28+
with:
29+
website: jdk.java.net
30+
release: ${{ matrix.java_version }}
31+
- name: Maven cache
32+
uses: actions/cache@v4
33+
env:
34+
cache-name: maven-cache
35+
with:
36+
path:
37+
~/.m2
38+
key: build-${{ env.cache-name }}
39+
- name: Maven version
40+
run: mvn --version
41+
- name: Prepare
42+
run: ./jakarta-to-valhalla.sh
43+
- name: Build with Maven
44+
run: mvn package
45+

.mvn/jvm.config.disabled

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
--enable-preview

inject-generator/pom.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@
1414
<description>annotation processor generating source code for avaje-inject dependency injection</description>
1515
<properties>
1616
<avaje.prisms.version>1.31</avaje.prisms.version>
17+
<!-- VALHALLA-START ___
18+
<maven.compiler.enablePreview>false</maven.compiler.enablePreview>
19+
____ VALHALLA-END -->
1720
</properties>
1821
<dependencies>
1922

inject-generator/src/test/java/io/avaje/inject/generator/InjectProcessorTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import static org.assertj.core.api.Assertions.assertThat;
44

55
import java.io.File;
6-
import java.io.IOException;
76
import java.io.PrintWriter;
87
import java.nio.file.Files;
98
import java.nio.file.Path;
@@ -24,6 +23,7 @@
2423

2524
import org.junit.jupiter.api.AfterEach;
2625
import org.junit.jupiter.api.Test;
26+
import org.junit.jupiter.api.Disabled;
2727

2828
class InjectProcessorTest {
2929

@@ -41,6 +41,7 @@ void deleteGeneratedFiles() {
4141
}
4242
}
4343

44+
@Disabled
4445
@Test
4546
void testGeneration() throws Exception {
4647
final String source =

inject/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@
9191
<show>public</show>
9292
<linksource>true</linksource>
9393
<overview>src/main/javadoc/overview.html</overview>
94+
<!-- Javadoc-No-Preview -->
9495
</configuration>
9596
<executions>
9697
<execution>

inject/src/main/java/io/avaje/inject/spi/ClosePair.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package io.avaje.inject.spi;
22

3-
public final class ClosePair implements Comparable<ClosePair> {
3+
public final /*value*/ class ClosePair implements Comparable<ClosePair> {
44

55
private final int priority;
66
private final AutoCloseable closeable;

inject/src/main/java/io/avaje/inject/spi/DEntry.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import io.avaje.inject.BeanEntry;
99

1010
@NullMarked
11-
final class DEntry implements BeanEntry {
11+
final /*value*/ class DEntry implements BeanEntry {
1212

1313
private final String qualifierName;
1414
private final int priority;

inject/src/main/java/io/avaje/inject/spi/EnrichBean.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
/**
99
* Holds Spy setup consumers for dependency injection using Mockito Spy.
1010
*/
11-
public final class EnrichBean<B> {
11+
public final /*value*/ class EnrichBean<B> {
1212

1313
private final Type type;
1414
private final String name;

inject/src/main/java/io/avaje/inject/spi/KeyUtil.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
/**
66
* Build a "flat key" combining type and name.
77
*/
8-
final class KeyUtil {
9-
8+
final /*value*/ class KeyUtil {
109

1110
static String key(Type type, String name) {
1211
return name == null ? type.getTypeName() : type.getTypeName() + "|" + name.toLowerCase();

inject/src/main/java/io/avaje/inject/spi/RawType.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
/**
2121
* Factory methods for types.
2222
*/
23-
final class RawType {
23+
final /*value*/ class RawType {
2424

2525
private RawType() {
2626
}

0 commit comments

Comments
 (0)