Skip to content

Commit 386227f

Browse files
committed
Remove dead code - more @request scope code from generator removed
1 parent 9719473 commit 386227f

File tree

4 files changed

+1
-39
lines changed

4 files changed

+1
-39
lines changed

inject-generator/src/main/java/io/avaje/inject/generator/MetaData.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ class MetaData {
1919
private final String name;
2020
private String method;
2121
private boolean wired;
22-
private boolean requestScope;
2322

2423
/**
2524
* The interfaces and class annotations the bean has (to register into lists).
@@ -32,7 +31,6 @@ class MetaData {
3231
private List<String> dependsOn;
3332

3433
MetaData(DependencyMeta meta) {
35-
this.requestScope = meta.requestScope();
3634
this.type = meta.type();
3735
this.name = trimName(meta.name());
3836
this.shortType = Util.shortName(type);
@@ -110,10 +108,6 @@ String getType() {
110108
return type;
111109
}
112110

113-
boolean isRequestScope() {
114-
return requestScope;
115-
}
116-
117111
List<String> getProvides() {
118112
return provides;
119113
}
@@ -154,9 +148,6 @@ String buildMethod(MetaDataOrdering ordering) {
154148

155149
StringBuilder sb = new StringBuilder(200);
156150
sb.append(" @DependencyMeta(type=\"").append(type).append("\"");
157-
if (requestScope) {
158-
sb.append(", requestScope=true");
159-
}
160151
if (name != null) {
161152
sb.append(", name=\"").append(name).append("\"");
162153
}

inject-generator/src/main/java/io/avaje/inject/generator/MetaDataOrdering.java

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ class MetaDataOrdering {
1313
private final ProcessingContext context;
1414
private final ScopeInfo scopeInfo;
1515
private final List<MetaData> orderedList = new ArrayList<>();
16-
private final List<MetaData> requestScope = new ArrayList<>();
1716
private final List<MetaData> queue = new ArrayList<>();
1817
private final Map<String, ProviderList> providers = new HashMap<>();
1918
private final List<DependencyLink> circularDependencies = new ArrayList<>();
@@ -23,11 +22,7 @@ class MetaDataOrdering {
2322
this.context = context;
2423
this.scopeInfo = scopeInfo;
2524
for (MetaData metaData : values) {
26-
if (metaData.isRequestScope()) {
27-
// request scoped expected to have externally provided dependencies
28-
requestScope.add(metaData);
29-
metaData.setWired();
30-
} else if (metaData.noDepends()) {
25+
if (metaData.noDepends()) {
3126
orderedList.add(metaData);
3227
metaData.setWired();
3328
} else {
@@ -195,18 +190,11 @@ List<MetaData> getOrdered() {
195190
return orderedList;
196191
}
197192

198-
List<MetaData> getRequestScope() {
199-
return requestScope;
200-
}
201-
202193
Set<String> getImportTypes() {
203194
Set<String> importTypes = new TreeSet<>();
204195
for (MetaData metaData : orderedList) {
205196
metaData.addImportTypes(importTypes);
206197
}
207-
for (MetaData metaData : requestScope) {
208-
metaData.addImportTypes(importTypes);
209-
}
210198
return importTypes;
211199
}
212200

inject-generator/src/main/java/io/avaje/inject/generator/SimpleModuleWriter.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import javax.tools.FileObject;
44
import java.io.IOException;
55
import java.io.Writer;
6-
import java.util.List;
76
import java.util.Set;
87
import java.util.TreeSet;
98

@@ -96,14 +95,6 @@ private void writeBuildMethod() {
9695
for (MetaData metaData : ordering.getOrdered()) {
9796
writer.append(" build_%s();", metaData.getBuildName()).eol();
9897
}
99-
final List<MetaData> requestScope = ordering.getRequestScope();
100-
if (!requestScope.isEmpty()) {
101-
writer.eol();
102-
writer.append(" // request scope providers").eol();
103-
for (MetaData metaData : requestScope) {
104-
writer.append(" build_%s();", metaData.getBuildName()).eol();
105-
}
106-
}
10798
writer.append(" }").eol();
10899
writer.eol();
109100
}
@@ -112,9 +103,6 @@ private void writeBuildMethods() {
112103
for (MetaData metaData : ordering.getOrdered()) {
113104
writer.append(metaData.buildMethod(ordering)).eol();
114105
}
115-
for (MetaData metaData : ordering.getRequestScope()) {
116-
writer.append(metaData.buildMethod(ordering)).eol();
117-
}
118106
}
119107

120108
private void writePackage() {

inject/src/main/java/io/avaje/inject/spi/DependencyMeta.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,6 @@
55
*/
66
public @interface DependencyMeta {
77

8-
/**
9-
* Request scope
10-
*/
11-
boolean requestScope() default false;
12-
138
/**
149
* The bean type.
1510
*/

0 commit comments

Comments
 (0)