Skip to content

Fix login screen accessibility: add form labels, lang attribute, and update link contrast (#1373) #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix login screen accessibility: add form labels, lang attribute, and update link contrast (#1373) #2252

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a2c943
Fix login screen accessibility: add form labels, lang attribute, and …
Dec 8, 2024
e46d86c
Merge branch 'master' into master
KesterTan Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/assets/stylesheets/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ $autolab-light-red: #ffbec0;
$autolab-subtle-gray: #eee;
$autolab-highlight-gray: #ccc;
$autolab-black-text: #212121;
$autolab-blue-text: #0869af;
$autolab-blue-text: #0056b3;
$autolab-green: #3a862d;
$autolab-light-green: #ebffd2;
$autolab-white: #fff;
Expand Down
12 changes: 9 additions & 3 deletions app/views/devise/sessions/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,19 @@
<div class="sign-in-panel home">
<div class="sign-in-panel home" lang="en">
<br>

<%= form_for(resource, as: resource_name, url: session_path(resource_name)) do |f| %>

<img src="/images/autolab.svg" alt="" class="valign login-logo">
<h5>Login to Autolab</h5>

<div><%= f.email_field :email, autofocus: true, placeholder: "Email Address" %></div>
<div><%= f.password_field :password, placeholder: "Password" %></div>
<div>
<%= f.label :email, "Email Address" %>
<%= f.email_field :email, autofocus: true, placeholder: "Email Address" %>
</div>
<div>
<%= f.label :password, "Password" %>
<%= f.password_field :password, placeholder: "Password" %>
</div>

<% if devise_mapping.rememberable? -%>
<label>
Expand Down
Loading