refactor: improve survey update logic by using $set operator for partial updates

Author: austenstone

backend/src/controllers/survey.controller.ts

@@ -123,14 +123,16 @@ class SurveyController {
     try {
       const Survey = mongoose.model('Survey');
       const { id } = req.params;
-      const updated = await Survey.findOneAndUpdate({
-        id: { $eq: Number(id) }
-      }, {
-        // we don't want to update all fields... just the ones passed in the body.
-        ...req.body,
-        hits: 0,
-        status: 'completed'
-      });
+      const updated = await Survey.findOneAndUpdate(
+        { id: { $eq: Number(id) } },
+        { 
+          $set: {
+            ...req.body,
+            hits: 0,
+            status: 'completed'
+          }
+        }
+      );
       if (updated) {
         res.status(200).json({ _id: id, ...req.body });
       } else {

backend/src/routes/index.ts

@@ -11,7 +11,6 @@ import mongoSanitize from 'express-mongo-sanitize';
 
 const router = Router();
 
-
 router.use(mongoSanitize());
 
 router.get('/', (req: Request, res: Response) => {

backend/src/services/survey.service.ts

@@ -16,8 +16,8 @@ class SurveyService {
       throw new Error('Invalid survey data provided');
     }
     const Survey = mongoose.model('Survey');
-    const result = await Survey.updateOne({ id: survey.id }, survey);
-
+    const result = await Survey.updateOne({ id: survey.id }, { $set: survey });
+    
     // Check if the update modified any document.
     if (result.modifiedCount === 0) {
       throw new Error('Survey update failed: no document was modified');

backend/src/services/target.service.ts

@@ -47,7 +47,7 @@ class TargetValuesService {
   async updateTargetValues(data: Targets) {
     try {
       const Targets = mongoose.model('Targets');
-      const targets = await Targets.findOneAndUpdate({}, data, { new: true, upsert: true });
+      const targets = await Targets.findOneAndUpdate({}, { $set: data }, { new: true, upsert: true });
       return targets;
     } catch (error) {
       throw new Error(`Error updating target values: ${error}`);