Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawn masks not commited to history #378

Closed
aurelienpierre opened this issue Oct 29, 2024 · 1 comment
Closed

Drawn masks not commited to history #378

aurelienpierre opened this issue Oct 29, 2024 · 1 comment

Comments

@aurelienpierre
Copy link
Collaborator

When adding drawn masks to a module, everything looks fine. When exiting to lighttable and re-entering to darkroom, most of the time, the last-added drawn mask is removed from its module. It still appears into the mask manager.

Collapsing history seems to prevent that. History needs a refactoring to make the control flow more linear, code is duplicated and convoluted.

@Annabel2
Copy link

Annabel2 commented Jan 7, 2025

By coincidence I was working with appimage 964 last night and still having problems with drawn masks not working. (Above you say collapsing history prevents, but I found it triggered the disappearance from the module).
I suppose the fix you've just made will be in the next appimage?
964 seems a lot less prone to crashing than the previous one, in fact I don't think it crashed at all last night, so Thank You for the good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants