From 34bd88b6d5f2293fade9f2ebcc48580f3033d95f Mon Sep 17 00:00:00 2001 From: August Date: Fri, 2 Feb 2018 09:53:21 -0800 Subject: [PATCH] Enabled status should not influence selected Changed isToolSelected() method to return only the selected value of a tool checkbox, regardless of whether the checkbox is enabled in the GUI. Fixes a bug that caused some requests to be inadvertently skipped in the passive scanner. --- pom.xml | 2 +- .../com/monikamorrow/burp/ToolsScopeComponent.java | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/pom.xml b/pom.xml index 4915fff..aa621ed 100644 --- a/pom.xml +++ b/pom.xml @@ -3,7 +3,7 @@ 4.0.0 com.codemagi burp-suite-utils - 1.2.0 + 1.2.1 jar Burp Suite Utils The Burp Suite Utils project provides developers with APIs for building Burp Suite Extensions. diff --git a/src/main/java/com/monikamorrow/burp/ToolsScopeComponent.java b/src/main/java/com/monikamorrow/burp/ToolsScopeComponent.java index 5087efb..5adb180 100644 --- a/src/main/java/com/monikamorrow/burp/ToolsScopeComponent.java +++ b/src/main/java/com/monikamorrow/burp/ToolsScopeComponent.java @@ -133,25 +133,25 @@ public boolean isToolSelected(int tool) { boolean selected = false; switch (tool) { case IBurpExtenderCallbacks.TOOL_PROXY: - selected = jCheckBoxProxy.isSelected() && jCheckBoxProxy.isEnabled(); + selected = jCheckBoxProxy.isSelected(); break; case IBurpExtenderCallbacks.TOOL_REPEATER: - selected = jCheckBoxRepeater.isSelected() && jCheckBoxRepeater.isEnabled(); + selected = jCheckBoxRepeater.isSelected(); break; case IBurpExtenderCallbacks.TOOL_SCANNER: - selected = jCheckBoxScanner.isSelected() && jCheckBoxScanner.isEnabled(); + selected = jCheckBoxScanner.isSelected(); break; case IBurpExtenderCallbacks.TOOL_INTRUDER: - selected = jCheckBoxIntruder.isSelected() && jCheckBoxIntruder.isEnabled(); + selected = jCheckBoxIntruder.isSelected(); break; case IBurpExtenderCallbacks.TOOL_SEQUENCER: - selected = jCheckBoxSequencer.isSelected() && jCheckBoxSequencer.isEnabled(); + selected = jCheckBoxSequencer.isSelected(); break; case IBurpExtenderCallbacks.TOOL_SPIDER: - selected = jCheckBoxSpider.isSelected() && jCheckBoxSpider.isEnabled(); + selected = jCheckBoxSpider.isSelected(); break; case IBurpExtenderCallbacks.TOOL_EXTENDER: - selected = jCheckBoxExtender.isSelected() && jCheckBoxExtender.isEnabled(); + selected = jCheckBoxExtender.isSelected(); break; case IBurpExtenderCallbacks.TOOL_TARGET: break;