From 173444e0fcdc9a99018642bf5de9f454706bd9fa Mon Sep 17 00:00:00 2001 From: Phanindra899 Date: Fri, 27 Mar 2026 17:34:36 +0530 Subject: [PATCH 1/2] Replace engine.connect() with engine.begin() in util.py Signed-off-by: Phanindra899 --- augur/api/routes/util.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/augur/api/routes/util.py b/augur/api/routes/util.py index 16d3c4db1d..943cd1a2bd 100644 --- a/augur/api/routes/util.py +++ b/augur/api/routes/util.py @@ -27,7 +27,7 @@ def get_all_repo_groups(): #TODO: make this name automatic - wrapper? ORDER BY rg_name """) - with current_app.engine.connect() as conn: + with current_app.engine.begin() as conn: results = pd.read_sql(repoGroupsSQL, conn) data = results.to_json(orient="records", date_format='iso', date_unit='ms') return Response(response=data, From c505e16633dee7a05826cc8890c9c27e10527d00 Mon Sep 17 00:00:00 2001 From: Phanindra899 Date: Sat, 28 Mar 2026 22:12:54 +0530 Subject: [PATCH 2/2] Use engine.begin() for DELETE operation and revert incorrect change on read-only query Signed-off-by: Phanindra899 --- augur/api/routes/util.py | 2 +- augur/tasks/data_analysis/insight_worker/tasks.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/augur/api/routes/util.py b/augur/api/routes/util.py index 943cd1a2bd..16d3c4db1d 100644 --- a/augur/api/routes/util.py +++ b/augur/api/routes/util.py @@ -27,7 +27,7 @@ def get_all_repo_groups(): #TODO: make this name automatic - wrapper? ORDER BY rg_name """) - with current_app.engine.begin() as conn: + with current_app.engine.connect() as conn: results = pd.read_sql(repoGroupsSQL, conn) data = results.to_json(orient="records", date_format='iso', date_unit='ms') return Response(response=data, diff --git a/augur/tasks/data_analysis/insight_worker/tasks.py b/augur/tasks/data_analysis/insight_worker/tasks.py index 97a6580d6f..d5b25174e1 100644 --- a/augur/tasks/data_analysis/insight_worker/tasks.py +++ b/augur/tasks/data_analysis/insight_worker/tasks.py @@ -106,7 +106,7 @@ def insight_model(repo_git: str,logger,engine) -> None: AND ri_date < :min_date """) - with engine.connect() as conn: + with engine.begin() as conn: result = conn.execute(delete_record_SQL, parameters=dict(repo_id=repo_id, min_date=min_date)) logger.info("Deleting out of date data points ...\n")