From 6f73852d9f091d358367d1edab913abc58d381dc Mon Sep 17 00:00:00 2001 From: Nathan Rockenbach Date: Wed, 6 Aug 2025 15:45:14 +0000 Subject: [PATCH 1/4] Fix multiline custom guidelines --- action.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/action.yml b/action.yml index 769cd2a..93cabcf 100644 --- a/action.yml +++ b/action.yml @@ -34,7 +34,9 @@ runs: shell: bash run: | if [ -n "$CUSTOM_GUIDELINES" ]; then - echo "context=$(jq -n --arg guidelines "$CUSTOM_GUIDELINES" '{custom_guidelines: $guidelines}')" >> $GITHUB_OUTPUT + echo 'context<> $GITHUB_OUTPUT + echo "$(jq -n --arg guidelines "$CUSTOM_GUIDELINES" '{custom_guidelines: $guidelines}')" >> $GITHUB_OUTPUT + echo 'EOF' >> $GITHUB_OUTPUT else echo "context={}" >> $GITHUB_OUTPUT fi From 6bd3c356f81e176865eecd2cecc3baba81162a46 Mon Sep 17 00:00:00 2001 From: Nathan Rockenbach Date: Wed, 6 Aug 2025 15:46:04 +0000 Subject: [PATCH 2/4] Add testing to describe action --- .github/workflows/describe-pr.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/describe-pr.yml b/.github/workflows/describe-pr.yml index dfd50e6..af8c47a 100644 --- a/.github/workflows/describe-pr.yml +++ b/.github/workflows/describe-pr.yml @@ -22,3 +22,8 @@ jobs: github_token: ${{ secrets.GITHUB_TOKEN }} pull_number: ${{ github.event.pull_request.number }} repo_name: ${{ github.repository }} + custom_guidelines: | + - Always reference Jira ticket numbers in brackets format (example: [ENG-123] or [PLAT-11169]) + - Always reference Jira ticket of the PR in the PR description near the top of PR + - Highlight any database migrations included in the changes + - Highlight any backfills included in the changes From 77da27bbff12b650151505c68da96506a916281b Mon Sep 17 00:00:00 2001 From: Nathan Rockenbach Date: Wed, 6 Aug 2025 15:48:38 +0000 Subject: [PATCH 3/4] Another test of old code --- .github/workflows/describe-pr.yml | 5 ----- .github/workflows/on-demand-describe.yml | 5 +++++ action.yml | 4 +--- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/.github/workflows/describe-pr.yml b/.github/workflows/describe-pr.yml index af8c47a..dfd50e6 100644 --- a/.github/workflows/describe-pr.yml +++ b/.github/workflows/describe-pr.yml @@ -22,8 +22,3 @@ jobs: github_token: ${{ secrets.GITHUB_TOKEN }} pull_number: ${{ github.event.pull_request.number }} repo_name: ${{ github.repository }} - custom_guidelines: | - - Always reference Jira ticket numbers in brackets format (example: [ENG-123] or [PLAT-11169]) - - Always reference Jira ticket of the PR in the PR description near the top of PR - - Highlight any database migrations included in the changes - - Highlight any backfills included in the changes diff --git a/.github/workflows/on-demand-describe.yml b/.github/workflows/on-demand-describe.yml index 5c94930..0c2f697 100644 --- a/.github/workflows/on-demand-describe.yml +++ b/.github/workflows/on-demand-describe.yml @@ -24,6 +24,11 @@ jobs: github_token: ${{ secrets.GITHUB_TOKEN }} pull_number: ${{ github.event.pull_request.number }} repo_name: ${{ github.repository }} + custom_guidelines: | + - Always reference Jira ticket numbers in brackets format (example: [ENG-123] or [PLAT-11169]) + - Always reference Jira ticket of the PR in the PR description near the top of PR + - Highlight any database migrations included in the changes + - Highlight any backfills included in the changes - name: Remove trigger label uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7 diff --git a/action.yml b/action.yml index 93cabcf..769cd2a 100644 --- a/action.yml +++ b/action.yml @@ -34,9 +34,7 @@ runs: shell: bash run: | if [ -n "$CUSTOM_GUIDELINES" ]; then - echo 'context<> $GITHUB_OUTPUT - echo "$(jq -n --arg guidelines "$CUSTOM_GUIDELINES" '{custom_guidelines: $guidelines}')" >> $GITHUB_OUTPUT - echo 'EOF' >> $GITHUB_OUTPUT + echo "context=$(jq -n --arg guidelines "$CUSTOM_GUIDELINES" '{custom_guidelines: $guidelines}')" >> $GITHUB_OUTPUT else echo "context={}" >> $GITHUB_OUTPUT fi From 38e44e23b37ad176d9e35db4d4624d212ba5d8d2 Mon Sep 17 00:00:00 2001 From: Nathan Rockenbach Date: Wed, 6 Aug 2025 15:50:15 +0000 Subject: [PATCH 4/4] Remove testing --- .github/workflows/on-demand-describe.yml | 5 ----- action.yml | 4 +++- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/workflows/on-demand-describe.yml b/.github/workflows/on-demand-describe.yml index 0c2f697..5c94930 100644 --- a/.github/workflows/on-demand-describe.yml +++ b/.github/workflows/on-demand-describe.yml @@ -24,11 +24,6 @@ jobs: github_token: ${{ secrets.GITHUB_TOKEN }} pull_number: ${{ github.event.pull_request.number }} repo_name: ${{ github.repository }} - custom_guidelines: | - - Always reference Jira ticket numbers in brackets format (example: [ENG-123] or [PLAT-11169]) - - Always reference Jira ticket of the PR in the PR description near the top of PR - - Highlight any database migrations included in the changes - - Highlight any backfills included in the changes - name: Remove trigger label uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7 diff --git a/action.yml b/action.yml index 769cd2a..93cabcf 100644 --- a/action.yml +++ b/action.yml @@ -34,7 +34,9 @@ runs: shell: bash run: | if [ -n "$CUSTOM_GUIDELINES" ]; then - echo "context=$(jq -n --arg guidelines "$CUSTOM_GUIDELINES" '{custom_guidelines: $guidelines}')" >> $GITHUB_OUTPUT + echo 'context<> $GITHUB_OUTPUT + echo "$(jq -n --arg guidelines "$CUSTOM_GUIDELINES" '{custom_guidelines: $guidelines}')" >> $GITHUB_OUTPUT + echo 'EOF' >> $GITHUB_OUTPUT else echo "context={}" >> $GITHUB_OUTPUT fi