CheckConnectionState: option to consider node as not synced if el_offline is true #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linter and tests seem to fail due to the same reasons as in #191 |
|
Which beacon node(s) exhibit this behavior? And is this an issue with the beacon node not supplying duties, or is it that the multi client fails to recognize that the beacon node is not supplying duties? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #171
The
multiclient doesn't switch clients if the current client's EL goes offline until the client setsis_syncingtotrue. It causes duty misses.The PR adds a
WithELConnectionCheckparameter to bothhttpandmulti, which makes the client consider a node as synced only ifel_offlineisfalseIt seems to work with Teku, Lighthouse, Nimbus correctly. It didn't work with Prysm because of prysmaticlabs/prysm#14226, its implementation of
el_offlineis incorrect, so the switch wouldn't happen until it started returning"is_syncing":true. So I added a temporary workaround for Prysm ifSyncDistance > 1