Skip to content
This repository was archived by the owner on Jun 11, 2024. It is now read-only.

Commit bf3f698

Browse files
committed
Add new models
Add `App`, `Appstore`, `City`, `Dma`, `Zipcode` models.
1 parent 0042c0f commit bf3f698

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

CHANGES.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,13 @@
66
- Add support to remove models from the API. See :meth:`atomx.models.AtomxModel.delete`.
77
- Add :meth:`atomx.Atomx.remove`.
88
- Add ``save`` parameter to :meth:`atomx.Atomx.report`.
9+
- Add new models:
10+
11+
* :class:`atomx.models.App`
12+
* :class:`atomx.models.Appstore`
13+
* :class:`atomx.models.City`
14+
* :class:`atomx.models.Dma`
15+
* :class:`atomx.models.Zipcode`
916

1017
1.5
1118
---

atomx/models.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,14 @@
1515
NoPandasInstalledError,
1616
)
1717

18-
__all__ = ['AccountManager', 'Advertiser', 'Bidder', 'Browser',
19-
'CampaignDebugReason', 'Campaign', 'Category', 'ConnectionType',
18+
# pylint: disable=undefined-all-variable
19+
__all__ = ['AccountManager', 'Advertiser', 'App', 'Appstore', 'Bidder', 'Browser', # noqa
20+
'CampaignDebugReason', 'Campaign', 'Category', 'ConnectionType', 'City',
2021
'ConversionPixel', 'Country', 'Creative', 'CreativeAttribute',
21-
'Datacenter', 'DeviceType', 'Domain', 'Fallback', 'Isp', 'Languages', 'Network',
22+
'Datacenter', 'DeviceType', 'Domain', 'Dma', 'Fallback', 'Isp', 'Languages', 'Network',
2223
'OperatingSystem', 'Placement', 'PlacementType', 'Profile', 'Publisher', 'Reason',
2324
'Segment', 'SellerProfile', 'Site', 'Size', 'User', 'Visibility',
24-
'Report']
25+
'Report', 'Zipcode'] # noqa
2526

2627

2728
class AtomxModel(object):

atomx/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def model_name_to_rest(name):
5959
resource name for the atomx api.
6060
E.g.::
6161
62-
>>> assert model_name_to_rest('ConversionPixels') == 'conversion-pixels'
62+
>>> assert model_name_to_rest('ConversionPixels') == 'conversion-pixels'
6363
>>> assert model_name_to_rest('OperatingSystem') == 'operating-system'
6464
>>> assert model_name_to_rest('Advertiser') == 'advertiser'
6565

0 commit comments

Comments
 (0)