add dlq-service during BB pipeline (#2617)

reverse optional dep logic and only add dlq-service during BB pipeline\

Author: gxueatlassian

.github/workflows/on-push.yml

@@ -18,10 +18,6 @@ jobs:
         with:
           path: '**/node_modules'
           key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
-      - name: remove internal package
-        run: |
-          sed -i '/sqs-queue-dlq-service/d' ./package.json
-          cat ./package.json
       - run: yarn install --frozen-lockfile
       - run: yarn run lint
       - run: yarn run build:release
@@ -35,10 +31,6 @@ jobs:
         with:
           path: '**/node_modules'
           key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
-      - name: remove internal package
-        run: |
-          sed -i '/sqs-queue-dlq-service/d' ./package.json
-          cat ./package.json
       - run: yarn install --frozen-lockfile
       - run: yarn run playwright install
       - name: create .env file
@@ -92,10 +84,6 @@ jobs:
         with:
           path: '**/node_modules'
           key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
-      - name: remove internal package
-        run: |
-          sed -i '/sqs-queue-dlq-service/d' ./package.json
-          cat ./package.json
       - run: yarn install --frozen-lockfile
       - run: yarn spa:build
       - name: create .env file
@@ -150,10 +138,6 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v1
-      - name: remove internal package
-        run: |
-          sed -i '/sqs-queue-dlq-service/d' ./package.json
-          cat ./package.json
       - name: Build Docker image
         uses: docker/[email protected]
         with:

.yarnrc

@@ -14,7 +14,6 @@ COPY . /app
 WORKDIR /app
 
 # Installing packages
-RUN sed -i '/sqs-queue-dlq-service/d' ./package.json
 RUN cat ./package.json
 RUN yarn install --frozen-lockfile
 

Dockerfile

@@ -18,7 +18,7 @@ COPY . /app
 WORKDIR /app
 
 # Installing packages
-RUN rm .yarnrc
+RUN yarn add @atlassian/sqs-queue-dlq-service
 RUN yarn install --frozen-lockfile
 RUN yarn list
 

Dockerfile.prod

@@ -182,9 +182,6 @@
 		"ts-node-dev": "^2.0.0",
 		"yaml-lint": "^1.2.4"
 	},
-	"optionalDependencies": {
-		"@atlassian/sqs-queue-dlq-service": "^2.1.1"
-	},
 	"volta": {
 		"node": "18.18.1",
 		"yarn": "1.22.18"

package.json

@@ -71,6 +71,5 @@
     "react-scripts": "^5.0.1",
     "ts-jest": "^29.1.1",
     "typescript": "^5.0.2"
-  },
-  "optionalDependencies": {}
+  }
 }