From dadf98995abbadc7e94f11dc8fee6987ccf7cbd8 Mon Sep 17 00:00:00 2001 From: Christopher Grote Date: Wed, 1 Nov 2023 11:38:45 +0000 Subject: [PATCH 1/2] Fix bug to allow multi-selects Signed-off-by: Christopher Grote --- .../src/main/kotlin/com/atlan/pkg/config/widgets/DropDown.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg-config/src/main/kotlin/com/atlan/pkg/config/widgets/DropDown.kt b/pkg-config/src/main/kotlin/com/atlan/pkg/config/widgets/DropDown.kt index a7c6276..f89cd86 100644 --- a/pkg-config/src/main/kotlin/com/atlan/pkg/config/widgets/DropDown.kt +++ b/pkg-config/src/main/kotlin/com/atlan/pkg/config/widgets/DropDown.kt @@ -35,7 +35,7 @@ class DropDown( ) { private class DropDownWidget( label: String, - mode: String, + val mode: String, hidden: Boolean = false, help: String = "", grid: Int, From 5bd0a7bd275e84e956a2602d52ba908d94df98cd Mon Sep 17 00:00:00 2001 From: Christopher Grote Date: Wed, 1 Nov 2023 11:42:44 +0000 Subject: [PATCH 2/2] Turn off propagation when no option is specified on a tag Signed-off-by: Christopher Grote --- .../migration-assistant-import/src/main/kotlin/CSVReader.kt | 1 - serde/src/main/kotlin/xformers/cell/AtlanTagXformer.kt | 3 +++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/migration-assistant-import/src/main/kotlin/CSVReader.kt b/packages/migration-assistant-import/src/main/kotlin/CSVReader.kt index 6416803..d208c0c 100644 --- a/packages/migration-assistant-import/src/main/kotlin/CSVReader.kt +++ b/packages/migration-assistant-import/src/main/kotlin/CSVReader.kt @@ -108,7 +108,6 @@ class CSVReader @JvmOverloads constructor(path: String, fieldSeparator: Char = ' if (assets.delete.isNotEmpty()) { deferDeletes[id]!![asset.guid] = assets.delete } - // TODO: Handle non-idempotent Atlan tags } catch (e: AtlanException) { logger.error("Unable to load batch.", e) } diff --git a/serde/src/main/kotlin/xformers/cell/AtlanTagXformer.kt b/serde/src/main/kotlin/xformers/cell/AtlanTagXformer.kt index ad368c2..929fb0f 100644 --- a/serde/src/main/kotlin/xformers/cell/AtlanTagXformer.kt +++ b/serde/src/main/kotlin/xformers/cell/AtlanTagXformer.kt @@ -48,6 +48,9 @@ object AtlanTagXformer { "HIERARCHY_ONLY" -> builder.propagate(true).removePropagationsOnEntityDelete(true).restrictPropagationThroughLineage(true) else -> builder.propagate(false) } + } else { + // If there is no propagation option specified, turn off propagation + builder.propagate(false) } return builder.build() }