fix: preflight error logging #789
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekagrawal-atlan
changed the title
📜 Docstring Coverage ReportRESULT: PASSED (minimum: 30.0%, actual: 75.5%) Detailed Coverage Report |
📦 Trivy Vulnerability Scan Results
Report Summary
Scan Result Details✅ No vulnerabilities found during the scan for |
📦 Trivy Secret Scan Results
Report Summary
Scan Result Details✅ No secrets found during the scan for |
|
🛠 Docs available at: https://k.atlan.dev/application-sdk/sdk-fixes |
inishchith
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| raise ValueError("Preflight check failed") | ||
| raise ValueError( | ||
| "Preflight check failed: " + str(result.get("error", "")) | ||
| ) |
There was a problem hiding this comment.
Bug: Calling .get() on potentially None result
When result is None (or another falsy value), the code attempts to call result.get("error", "") which raises an AttributeError since None doesn't have a .get() method. The condition if not result or "error" in result short-circuits and enters the if block when result is falsy, but then tries to access .get() on that falsy value.
| return match.group(1) | ||
| raise ValueError("Could not find valid AWS region from hostname") | ||
| logger.warning("Could not find valid AWS region from hostname") | ||
| return None |
There was a problem hiding this comment.
Bug: Returning None region breaks downstream boto3 clients
Changing get_region_name_from_hostname to return None instead of raising ValueError causes downstream issues. When callers like generate_aws_rds_token_with_iam_role and generate_aws_rds_token_with_iam_user use the expression region or get_region_name_from_hostname(host), they'll pass None to boto3's region_name parameter if both region is None and the hostname doesn't contain a valid region. This will cause AWS SDK errors since boto3 requires a valid region to make API calls.
Additional Locations (2)
inishchith
reviewed
Dec 9, 2025
Member
inishchith
left a comment
inishchith
left a comment
There was a problem hiding this comment.
@abhishekagrawal-atlan - the unit tests are failing, PTAL
📦 Example workflows test results
|
📦 Example workflows test results
|
📦 Example workflows test results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…reflight logging
Changelog
Additional context (e.g. screenshots, logs, links)
Checklist
Copyleft License Compliance
Note
Enhances preflight error messaging and changes AWS region extraction to warn and return None instead of raising.
preflight_checkerror reporting by raisingValueErrorwith detailed message fromresult.get("error", "")when preflight fails.get_region_name_from_hostnameto returnNoneand log a warning when no region is found (was raising an exception).str | Noneaccordingly.Written by Cursor Bugbot for commit 3c7a111. This will update automatically on new commits. Configure here.