Skip to content

README.md #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drahnr opened this issue Mar 22, 2020 · 4 comments
Open

README.md #2

drahnr opened this issue Mar 22, 2020 · 4 comments

Comments

@drahnr
Copy link

drahnr commented Mar 22, 2020

Could you add a small intro and possibly consider publishing on crates.io :)

@athei
Copy link
Owner

athei commented Mar 22, 2020

There are some things that kept me from releasing. Mostly that there are panics all over the code base and that there are some vital features missing that I need. The only thing that really bothers me is this bug in rustfmt that defeats the whole purpose of this crate.

That said, maybe I can do a minimal release for the three users of this crate :)

@elichai
Copy link

elichai commented Mar 30, 2020

@athei I was about to start writing a similar crate and stumbled upon this.
Would you be open to a quick talk about the crate?

  1. are you planing on maintaining it and keep developing or is it a weekend project?
  2. have you thought about being using rustfmt as a dependency instead of using it through the command line?
  3. about the bug, what about extending the line count until the next ;?.

I'm on Zulip,Discord and IRC. so if you want to talk please ping me :) (elichai2)

@athei
Copy link
Owner

athei commented Mar 30, 2020

are you planing on maintaining it and keep developing or is it a weekend project?

I don't think I will be putting much work into it right now. So so the latter one is true.

have you thought about being using rustfmt as a dependency instead of using it through the command line?

I actually tried that and it was not working for some reason (It did not format even though I passed the correct lines). I refactored the code so it is now at least easy to add the dependency version as a Formatter. Idea there is that it will also work with other tools like clang-format.

about the bug, what about extending the line count until the next ;?.

Or the next } I guess. Never thought of that. Might be a good fix. The context line must be removed then. It already triggered unwanted formats for me.

I'm on Zulip,Discord and IRC. so if you want to talk please ping me :) (elichai2)

Only have discord. Tried elichai2. It says I need a four digit tag.

@elichai
Copy link

elichai commented Mar 30, 2020

Thanks for the quick response :)

Only have discord. Tried elichai2. It says I need a four digit tag.

elichai2#0169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants