Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [New Demo Request]: Contact Picker API Demo #128

Open
atapas opened this issue Oct 28, 2021 · 8 comments
Open

✨ [New Demo Request]: Contact Picker API Demo #128

atapas opened this issue Oct 28, 2021 · 8 comments
Assignees
Labels
enhancement New feature or request hacktoberfest hacktoberfest

Comments

@atapas
Copy link
Owner

atapas commented Oct 28, 2021

Please include the request by answering these questions.

What is the Example and Demo Topic?

Contact Picker API

Please explain why do you need it?

It works on mobile devices and Opera so far. It would be great to get this demo done.

Any Links, Reads?

https://developer.mozilla.org/en-US/docs/Web/API/Contact_Picker_API

If you are picking up this request to implement, PLEASE READ THIS

@atapas atapas added the enhancement New feature or request label Oct 28, 2021
@ShivamArora
Copy link

Hi @atapas, I would love to contribute to this. Can you please assign this to me?

@ShivamArora
Copy link

Thanks for assigning this to me @atapas. I've generated the boilerplate using the gen-demo script.

However, it seems like there's two different conventions in the code at the moment.

The data is stored at two different places modules/apis/data.ts and utils/demos.js.

There are two different modules in the repo web-apis and modules.

And although the repo mentions we can use either typescript/javascript, it seems all the pages have been written in Javascript.

Also, the gen-demo script doesn't generate boilerplate required within the pages directory.

Can you please help in clarifying which files are being currently used and if the project is undergoing a migration, which folder/files are to be deprecated so I don't write my code in those files?

@atapas
Copy link
Owner Author

atapas commented Nov 7, 2021

Hey @ShivamArora,

I'm off of a medical leave. @mverissimo @niteshseram @max-programming will be able to help you out.

@ShivamArora
Copy link

No worries. Take care @atapas 😃

@mverissimo
Copy link
Contributor

Thanks for assigning this to me @atapas. I've generated the boilerplate using the gen-demo script.

However, it seems like there's two different conventions in the code at the moment.

The data is stored at two different places modules/apis/data.ts and utils/demos.js.

There are two different modules in the repo web-apis and modules.

And although the repo mentions we can use either typescript/javascript, it seems all the pages have been written in Javascript.

Also, the gen-demo script doesn't generate boilerplate required within the pages directory.

Can you please help in clarifying which files are being currently used and if the project is undergoing a migration, which folder/files are to be deprecated so I don't write my code in those files?

The codebase is being refactored to typescript and will be merged soon, you can write in js or ts but our preference is ts, will need to update the plopfile to generate js too.

@ShivamArora
Copy link

Hi @mverissimo, I was writing my code in Typescript only but seems some components(DemoInfo, DemoSEO) are still written in JS using the older schema for demo [ùtils/demos.js] and are pretty heavily dependent on that older schema making the newer schema useless since we've to duplicate our code for older schema as well.

Is it going to change anytime soon so we can avoid that duplication?

@ShivamArora
Copy link

Also, please correct me if I'm missing something that can help avoid code duplication.

@mverissimo
Copy link
Contributor

Also, please correct me if I'm missing something that can help avoid code duplication.

The project was refactored, I suggest you start your demo from the develop branch, to avoid these problems.

@atapas atapas added the hacktoberfest hacktoberfest label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants