feat: Add ability to get SmtpStream from SmtpTransport #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
reviewed
Oct 13, 2024
src/smtp_client.rs
Outdated
| @@ -123,6 +123,11 @@ impl<S: BufRead + Write + Unpin> SmtpTransport<S> { | |||
| Ok(transport) | |||
| } | |||
|
|
|||
| /// Get the underlying SmtpStream. | |||
| pub fn get_stream(&mut self) -> &mut SmtpStream<S> { | |||
There was a problem hiding this comment.
This is usually named get_mut(), see for example https://docs.rs/tokio-rustls/latest/tokio_rustls/enum.TlsStream.html and https://docs.rs/tokio/latest/tokio/io/struct.BufWriter.html#method.get_mut
I would also provide get_ref() before it to get non-mutable reference, and maybe also into_inner() which is another common method.
There was a problem hiding this comment.
Makes sense. Added get_mut, get_ref and into_inner
amaury1093
changed the title
link2xt
approved these changes
Oct 14, 2024
|
Thanks! |
|
Thanks! Any chance you can tag a 0.9.2? |
|
Just tagged and published |
|
Thanks @link2xt for your reactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am the author of https://github.com/reacherhq/check-if-email-exists, and I currently use async-smtp 0.6. I would like to upgrade to 0.9, but I'm blocked on one small feature missing in this library.
The check-if-email-exists lib manually sends the EHLO, MAIL FROM, RCPT commands, but does not actually send the email. Looking at the SmtpClient, it only exposes the
send()function, which does MAIL FROM, RCPT, DATA and sending. It seems like there's no way to have more granularity on the SMTP commands.I would like to propose this small addition so that I can upgrade to 0.9 and continue using this great library without forking.
Thanks for considering.