Skip to content

Commit 07e22b7

Browse files
cleanup comments to self
1 parent 4fb90c7 commit 07e22b7

File tree

5 files changed

+5
-8
lines changed

5 files changed

+5
-8
lines changed

halotools/mock_observables/large_scale_density/large_scale_density_spherical_volume.py

-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
np.seterr(divide='ignore', invalid='ignore') # ignore divide by zero in e.g. DD/RR
1919

2020

21-
# cbx: I think all the code here could pretty easily be replaced with that of `large_scale_density_spherical_annulus`
2221
def large_scale_density_spherical_volume(sample, tracers, radius,
2322
period=None, sample_volume=None, num_threads=1, approx_cell1_size=None,
2423
norm_by_mean_density=False):

halotools/mock_observables/pairwise_velocities/mean_radial_velocity_vs_r.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ def mean_radial_velocity_vs_r(sample1, velocities1,
169169
"""
170170
result = _process_args(sample1, velocities1, sample2, velocities2,
171171
rbins_absolute, rbins_normalized, normalize_rbins_by,
172-
period, num_threads, approx_cell1_size, approx_cell2_size, None)
172+
period, num_threads, approx_cell1_size, approx_cell2_size)
173173

174174
sample1, velocities1, sample2, velocities2, max_rbins_absolute, period,\
175175
num_threads, _sample1_is_sample2, PBCs, \
@@ -230,7 +230,7 @@ def mean_radial_velocity_vs_r(sample1, velocities1,
230230

231231
def _process_args(sample1, velocities1, sample2, velocities2,
232232
rbins_absolute, rbins_normalized, normalize_rbins_by,
233-
period, num_threads, approx_cell1_size, approx_cell2_size, seed):
233+
period, num_threads, approx_cell1_size, approx_cell2_size):
234234
"""
235235
Private method to do bounds-checking on the arguments passed to
236236
`~halotools.mock_observables.pairwise_velocity_stats`.

halotools/mock_observables/pairwise_velocities/radial_pvd_vs_r.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ def radial_pvd_vs_r(sample1, velocities1,
167167
"""
168168
result = _process_args(sample1, velocities1, sample2, velocities2,
169169
rbins_absolute, rbins_normalized, normalize_rbins_by,
170-
period, num_threads, approx_cell1_size, approx_cell2_size, None)
170+
period, num_threads, approx_cell1_size, approx_cell2_size)
171171

172172
sample1, velocities1, sample2, velocities2, max_rbins_absolute, period,\
173173
num_threads, _sample1_is_sample2, PBCs, \

halotools/mock_observables/pairwise_velocities/velocity_marked_npairs_3d.py

-1
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,6 @@ def _func_signature_int_from_vel_weight_func_id(weight_func_id):
289289
msg = "\n weight_func_id parameter must be an integer ID of a weighting function."
290290
raise HalotoolsError(msg)
291291

292-
# cbx: seriousl you need 6 weights?
293292
elif weight_func_id == 1:
294293
return 6
295294
elif weight_func_id == 2:

halotools/mock_observables/two_point_clustering/angular_tpcf.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ def area_spherical_cap(chord):
184184
elif randoms is None:
185185

186186
# set the number of randoms equal to the number of points in sample1
187-
# cbx: Why not use much more? Less noise at no cost right?
187+
# cbx: Maybe stupid question but why not use much more? Less noise at no cost right?
188188
NR = len(sample1)
189189

190190
# do area calculations
@@ -202,7 +202,7 @@ def area_spherical_cap(chord):
202202
D2R = N2*(da*rho2)
203203

204204
# calculate the random-random pairs.
205-
# cbx: This should be NR(NR-1) if we are doing an autocorr
205+
# cbx: This should be NR(NR-1) if we are doing an autocorr I think? Maybe it doesn't matter.
206206
rhor = NR**2/global_area
207207
RR = (da*rhor)
208208

@@ -239,7 +239,6 @@ def pair_counts(sample1, sample2, chord_bins,
239239
return D1D1, D1D2, D2D2
240240

241241
# What needs to be done?
242-
# cbx: do_DD is never used
243242
do_DD, do_DR, do_RR = _TP_estimator_requirements(estimator)
244243

245244
# How many points are there (for normalization purposes)?

0 commit comments

Comments
 (0)