-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the repository
and homepage
warnings when not present in package.json
#75
Comments
Thanks for opening an issue on this! I agree, these warnings can feel like overkill, especially for this use case. I haven't documented this yet, but I tried to get around this by adding the ability to silence these warning if the Context for these warnings: The main reason I want to support these warning is that the integrations page is populated automatically. This means It is possible for user's to publish their package with undefined fields, which makes it harder for people to discover the theme on the integrations page. The goal of these warnings are to make sure that themes authored with ATP follow best practices and are discoverable by the Astro. |
Ahh, awesome! I just tried the |
Good idea! 📋 I also plan on writing some docs to cover these options/use cases |
If anyone is interested in contributing, this is a great first issue! Here is the code for these warnings: https://github.com/astrolicious/astro-theme-provider/blob/main/package/src/utils/package.ts#L38 If any of these warnings are triggered, we should also warn that they can be silenced with |
and add notice to use `'private': true` suppress these warnings
There are use cases where a user doesn't want to publish their theme (such as if private or just testing something). The warnings that are emitted I feel are a tiny bit over-kill (especially when first getting started with the example repo):
If the intention is to use this package for preparing a user to submit their theme to the Astro integration page then maybe a
validate
command could be added? This could check if everything is correct and also give a developer any additional context.The text was updated successfully, but these errors were encountered: