Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] source.* warns agains boolean values #712

Open
sarpuser opened this issue Mar 6, 2025 · 2 comments
Open

[Bug] source.* warns agains boolean values #712

sarpuser opened this issue Mar 6, 2025 · 2 comments
Labels
question Asking for support or clarification

Comments

@sarpuser
Copy link

sarpuser commented Mar 6, 2025

When I put an incorrect value in the the source.* stars, I get the following error:

Value is not accepted. Valid values: "always", "explicit", "never", true, false.

However, when I put the boolean true or false in the settings, I get a warning that says Incorrect type. Expected "string". The values still toggle linting behaviour as expected, but the warning remains.

@MichaReiser
Copy link
Member

Could you share your entire VS config or at least the parts where you set the source.*? It's otherwise difficult to help you

@MichaReiser MichaReiser added the question Asking for support or clarification label Mar 7, 2025
@dhruvmanila
Copy link
Member

Are you referring to the source.organizeImports / source.fixAll code actions that you're setting in editor.codeActionsOnSave or notebook.codeActionsOnSave? I think that's unrelated to the extension because VS Code has deprecated the boolean values in those fields. Refer to #313 which has some links to the VS Code repository. Maybe, they've made this a hard error with the recent update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Asking for support or clarification
Projects
None yet
Development

No branches or pull requests

3 participants