Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff extension depends on ms-python.python breaking non-Pylance LSPs #636

Open
felixm-stripe opened this issue Oct 25, 2024 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@felixm-stripe
Copy link

felixm-stripe commented Oct 25, 2024

Hi!

At Stripe we use Ruff to check our code (very happy with the speed, UX, and lints available). However, we also rely on a different LSP to type-check the code properly at scale. That LSP is incompatible with Pylance, and as such, Pylance needs to be disabled.

Since the Ruff extension depends on ms-python.python, and it in turn automatically installs and enables Pylance, our engineers are forced to manually intervene to disable Pylance whenever the Ruff extension gets re-installed / updated. Currently, there's no way to configure banned extensions in VSCode, so we have tooling to instead remove the extensions when we push an update. However, sometimes Ruff gets updated out of band.

Could we remove the reliance on ms-python.python in the Ruff extension?

@MichaReiser
Copy link
Member

Thanks for the kind words!

This is related to #479

@MichaReiser MichaReiser added the enhancement New feature or request label Oct 25, 2024
@dhruvmanila
Copy link
Member

Is it possible to use the "python.languageServer": "None" setting? This will at least disable any language server from running via the Python extension.

@felixm-stripe
Copy link
Author

It seems that other LSPs like Pyright check if Pylance is enabled and if so turns itself off. I can file an issue there as well, but ultimately, we might need to remove the reliance on the Python extension altogether so while helpful, I think the core issue is still relevant! ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants