Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a missing super-init in the GEVD beamformer class #707

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

ovistetom
Copy link
Contributor

Seems like there was a missing super().__init__() in the GEV-D beamformer class definition, causing improper inheritance of attributes from the parent Beamformer class.
Notably, this is not the case for the SDW-WMF beamformer class definition.
Caused an error when calling a beamformer instance.

>>> import asteroid.dsp.beamforming as bf
>>> beamformer = bf.GEVDBeamformer()
>>> stft_enhanced = beamformer(mix=signal_noisy, target_scm=psd_clean, noise_scm=psd_noise)
AttributeError: 'GEVDBeamformer' object has no attribute '_backward_hooks'

@mpariente
Copy link
Collaborator

Thank you !

@mpariente mpariente merged commit 4ee4958 into asteroid-team:master Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants