Skip to content

Commit a3ee15c

Browse files
author
Joseph Cooper
committed
Rename Throwable extractor functions
Prior functions are deprecated
1 parent 6b65668 commit a3ee15c

File tree

4 files changed

+37
-18
lines changed

4 files changed

+37
-18
lines changed

assertk/src/commonMain/kotlin/assertk/assertions/throwable.kt

Lines changed: 29 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,38 +6,59 @@ import assertk.all
66
/**
77
* Returns an assert on the throwable's message.
88
*/
9-
fun Assert<Throwable>.message() = having("message", Throwable::message)
9+
fun Assert<Throwable>.havingMessage() = having("message", Throwable::message)
10+
11+
@Deprecated(
12+
message = "Function message has been renamed to havingMessage",
13+
replaceWith = ReplaceWith("havingMessage()"),
14+
level = DeprecationLevel.WARNING
15+
)
16+
fun Assert<Throwable>.message() = havingMessage()
1017

1118
/**
1219
* Returns an assert on the throwable's cause.
1320
*/
14-
fun Assert<Throwable>.cause() = having("cause", Throwable::cause)
21+
fun Assert<Throwable>.havingCause() = having("cause", Throwable::cause)
22+
23+
@Deprecated(
24+
message = "Function cause has been renamed to havingCause",
25+
replaceWith = ReplaceWith("havingCause()"),
26+
level = DeprecationLevel.WARNING
27+
)
28+
fun Assert<Throwable>.cause() = havingCause()
1529

1630
/**
1731
* Returns an assert on the throwable's root cause.
1832
*/
19-
fun Assert<Throwable>.rootCause() = having("rootCause", Throwable::rootCause)
33+
fun Assert<Throwable>.havingRootCause() = having("rootCause", Throwable::rootCause)
34+
35+
@Deprecated(
36+
message = "Function rootCause has been renamed to havingRootCause",
37+
replaceWith = ReplaceWith("havingRootCause()"),
38+
level = DeprecationLevel.WARNING
39+
)
40+
fun Assert<Throwable>.rootCause() = havingRootCause()
2041

2142
/**
2243
* Asserts the throwable has the expected message.
2344
*/
2445
fun Assert<Throwable>.hasMessage(message: String?) {
25-
message().isEqualTo(message)
46+
havingMessage().isEqualTo(message)
2647
}
2748

2849
/**
2950
* Asserts the throwable contains the expected text
3051
*/
3152
fun Assert<Throwable>.messageContains(text: String) {
32-
message().isNotNull().contains(text)
53+
havingMessage().isNotNull().contains(text)
3354
}
3455

3556
/**
3657
* Asserts the throwable is similar to the expected cause, checking the type and message.
3758
* @see [hasNoCause]
3859
*/
3960
fun Assert<Throwable>.hasCause(cause: Throwable) {
40-
cause().isNotNull().all {
61+
havingCause().isNotNull().all {
4162
kClass().isEqualTo(cause::class)
4263
hasMessage(cause.message)
4364
}
@@ -48,14 +69,14 @@ fun Assert<Throwable>.hasCause(cause: Throwable) {
4869
* @see [hasCause]
4970
*/
5071
fun Assert<Throwable>.hasNoCause() {
51-
cause().isNull()
72+
havingCause().isNull()
5273
}
5374

5475
/**
5576
* Asserts the throwable is similar to the expected root cause, checking the type and message.
5677
*/
5778
fun Assert<Throwable>.hasRootCause(cause: Throwable) {
58-
rootCause().all {
79+
havingRootCause().all {
5980
kClass().isEqualTo(cause::class)
6081
hasMessage(cause.message)
6182
}

assertk/src/commonTest/kotlin/test/assertk/AssertFailureTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package test.assertk
33
import assertk.assertFailure
44
import assertk.assertions.isEqualTo
55
import assertk.assertions.isInstanceOf
6-
import assertk.assertions.message
6+
import assertk.assertions.havingMessage
77
import com.willowtreeapps.opentest4k.AssertionFailedError
88
import test.assertk.assertions.valueOrFail
99
import kotlin.coroutines.resume
@@ -28,7 +28,7 @@ class AssertFailureTest {
2828
fun failure_originating_subject_not_wrapped_in_result() {
2929
val t = assertFailsWith<AssertionFailedError> {
3030
assertFailure { throw RuntimeException("foo") }
31-
.message()
31+
.havingMessage()
3232
.isEqualTo("bar")
3333
}
3434
assertTrue("RuntimeException" in t.message!!)

assertk/src/commonTest/kotlin/test/assertk/assertions/ThrowableTest.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,17 @@ class ThrowableTest {
1414

1515
@Test
1616
fun extracts_message() {
17-
assertEquals(subject.message, assertThat(subject).message().valueOrFail)
17+
assertEquals(subject.message, assertThat(subject).havingMessage().valueOrFail)
1818
}
1919

2020
@Test
2121
fun extracts_cause() {
22-
assertEquals(cause, assertThat(subject).cause().valueOrFail)
22+
assertEquals(cause, assertThat(subject).havingCause().valueOrFail)
2323
}
2424

2525
@Test
2626
fun extracts_root_cause() {
27-
assertEquals(rootCause, assertThat(subject).rootCause().valueOrFail)
27+
assertEquals(rootCause, assertThat(subject).havingRootCause().valueOrFail)
2828
}
2929

3030
//region hasMessage

assertk/src/commonTest/kotlin/test/assertk/assertions/support/SupportTest.kt

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
package test.assertk.assertions.support
22

33
import assertk.assertThat
4-
import assertk.assertions.hasMessage
5-
import assertk.assertions.isEqualTo
64
import assertk.assertions.isFailure
75
import assertk.assertions.isSuccess
8-
import assertk.assertions.message
6+
import assertk.assertions.havingMessage
97
import assertk.assertions.support.expected
108
import assertk.assertions.support.fail
119
import assertk.assertions.support.show
@@ -236,7 +234,7 @@ class SupportTest {
236234
@Test
237235
fun expected_originating_throwable_included_as_cause() {
238236
val subject = RuntimeException()
239-
val assert = assertThat(subject).message()
237+
val assert = assertThat(subject).havingMessage()
240238
val error = assertFailsWith<AssertionFailedError> {
241239
assert.expected("message")
242240
}
@@ -246,7 +244,7 @@ class SupportTest {
246244
@Test
247245
fun expected_originating_failure_result_included_as_cause() {
248246
val subject = RuntimeException()
249-
val assert = assertThat(Result.failure<String>(subject)).isFailure().message()
247+
val assert = assertThat(Result.failure<String>(subject)).isFailure().havingMessage()
250248
val error = assertFailsWith<AssertionFailedError> {
251249
assert.expected("message")
252250
}

0 commit comments

Comments
 (0)