feat: support prod and dev deps on npm_link_all_packages and npm_link_targets (#2298)

### Changes are visible to end-users: yes

- Searched for relevant documentation and updated as needed: yes
- Breaking change (forces users to change their own code or config): no
- Suggested release notes appear below: yes

Added prod only and dev only options for npm_link_all_packages and
npm_link_targets rules

### Test plan

- New test cases added

Fixes: #1879

Author: Mivr

docs/npm_link_all_packages.md

@@ -1,13 +1,38 @@
 load("@aspect_bazel_lib//lib:write_source_files.bzl", "write_source_files")
+load("@aspect_rules_js//js:defs.bzl", "js_test")
 load("@bazel_skylib//rules:build_test.bzl", "build_test")
-load("@npm//:defs.bzl", "npm_link_all_packages")
+load("@npm//:defs.bzl", "npm_link_all_packages", "npm_link_targets")
 
 npm_link_all_packages(name = "node_modules")
 
+PROD_TARGETS = npm_link_targets(
+    dev = False,
+    prod = True,
+)
+
+DEV_TARGETS = npm_link_targets(
+    dev = True,
+    prod = False,
+)
+
+js_test(
+    name = "test_prod_filtering",
+    data = PROD_TARGETS,
+    entry_point = "test_prod_filtering.js",
+)
+
+js_test(
+    name = "test_dev_filtering",
+    data = DEV_TARGETS,
+    entry_point = "test_dev_filtering.js",
+)
+
 build_test(
     name = "test",
     targets = [
         ":node_modules",
+        ":test_prod_filtering",
+        ":test_dev_filtering",
     ],
 )
 

e2e/npm_translate_lock/BUILD.bazel

@@ -0,0 +1,14 @@
+// Crash if dev deps missing
+require('@rollup/plugin-commonjs');
+require('@rollup/plugin-json');
+require('@rollup/plugin-node-resolve');
+
+// Crash if prod deps present (filtering failed)
+try {
+  require('debug');
+  throw new Error('PROD DEPENDENCY LEAKED INTO DEV BUILD');
+} catch (e) {
+  if (e.code !== 'MODULE_NOT_FOUND') throw e;
+}
+
+console.log('✅ Development filtering validated');

e2e/npm_translate_lock/test_dev_filtering.js

@@ -0,0 +1,14 @@
+// Crash if prod deps missing
+require('debug');
+require('is-odd'); 
+require('semver');
+
+// Crash if dev deps present (filtering failed)
+try {
+  require('@rollup/plugin-commonjs');
+  throw new Error('DEV DEPENDENCY LEAKED INTO PROD BUILD');
+} catch (e) {
+  if (e.code !== 'MODULE_NOT_FOUND') throw e;
+}
+
+console.log('✅ Production filtering validated');