Skip to content

Commit 24240bb

Browse files
authored
perf: set include_runfiles to False in all npm_package examples (#145)
1 parent f01e2dd commit 24240bb

File tree

8 files changed

+16
-0
lines changed

8 files changed

+16
-0
lines changed

angular-ngc/defs.bzl

+2
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,8 @@ def ng_pkg(name, deps = [], test_deps = [], visibility = ["//visibility:public"]
265265
npm_package(
266266
name = name,
267267
srcs = ["package.json", ":_lib"],
268+
# This is a perf improvement; the default will be flipped to False in rules_js 2.0
269+
include_runfiles = False,
268270
visibility = ["//visibility:public"],
269271
)
270272

next.js/packages/one/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,7 @@ npm_package(
3030
"package.json",
3131
":one_ts",
3232
],
33+
# This is a perf improvement; the default will be flipped to False in rules_js 2.0
34+
include_runfiles = False,
3335
visibility = ["//visibility:public"],
3436
)

pnpm-workspaces/packages/first/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,7 @@ npm_package(
77
"package.json",
88
"src/main.js",
99
],
10+
# This is a perf improvement; the default will be flipped to False in rules_js 2.0
11+
include_runfiles = False,
1012
visibility = ["//visibility:public"],
1113
)

pnpm-workspaces/packages/one/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,7 @@ npm_package(
1717
"package.json",
1818
":one_ts",
1919
],
20+
# This is a perf improvement; the default will be flipped to False in rules_js 2.0
21+
include_runfiles = False,
2022
visibility = ["//visibility:public"],
2123
)

pnpm-workspaces/packages/shared/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,7 @@ npm_package(
1717
"package.json",
1818
"src/main.js",
1919
],
20+
# This is a perf improvement; the default will be flipped to False in rules_js 2.0
21+
include_runfiles = False,
2022
visibility = ["//visibility:public"],
2123
)

pnpm-workspaces/packages/two/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,7 @@ npm_package(
1111
"//:node_modules/@bazel-poc/first",
1212
"//:node_modules/cowsay",
1313
],
14+
# This is a perf improvement; the default will be flipped to False in rules_js 2.0
15+
include_runfiles = False,
1416
visibility = ["//visibility:public"],
1517
)

rules_nodejs_to_rules_js_migration/packages/a/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -42,5 +42,7 @@ npm_package(
4242
"package.json",
4343
":a_rjs",
4444
],
45+
# This is a perf improvement; the default will be flipped to False in rules_js 2.0
46+
include_runfiles = False,
4547
visibility = ["//visibility:public"],
4648
)

vue/libraries/simple/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,7 @@ npm_package(
4444
"copy_esm",
4545
"package.json",
4646
],
47+
# This is a perf improvement; the default will be flipped to False in rules_js 2.0
48+
include_runfiles = False,
4749
visibility = ["//visibility:public"],
4850
)

0 commit comments

Comments
 (0)