fix: empty bulk create inputs must still return a stream

closes #1784

Author: zachdaniel

lib/ash.ex

@@ -2410,19 +2410,23 @@ defmodule Ash do
 
     case inputs do
       [] ->
-        result = %Ash.BulkResult{status: :success, errors: []}
+        if opts[:return_stream?] do
+          []
+        else
+          result = %Ash.BulkResult{status: :success, errors: []}
 
-        result =
-          if opts[:return_records?] do
-            %{result | records: []}
+          result =
+            if opts[:return_records?] do
+              %{result | records: []}
+            else
+              result
+            end
+
+          if opts[:return_notifications?] do
+            %{result | notifications: []}
           else
             result
           end
-
-        if opts[:return_notifications?] do
-          %{result | notifications: []}
-        else
-          result
         end
 
       inputs ->

test/actions/bulk/bulk_create_test.exs

@@ -1200,6 +1200,19 @@ defmodule Ash.Test.Actions.BulkCreateTest do
   end
 
   describe "streaming" do
+    test "a stream is returned when inputs are empty" do
+      assert [] =
+               []
+               |> Ash.bulk_create!(
+                 Post,
+                 :create_with_policy,
+                 authorize?: true,
+                 return_stream?: true,
+                 return_records?: true
+               )
+               |> Enum.to_list()
+    end
+
     test "by default nothing is returned in the stream" do
       org =
         Org

test/actions/update_test.exs

@@ -1,7 +1,7 @@
 defmodule Ash.Test.Actions.UpdateTest do
   @moduledoc false
   require Ash.Flags
-  use ExUnit.Case, async: true
+  use ExUnit.Case, async: false
 
   import Ash.Test
   require Ash.Query