Expose descriptor metadata: name, relation, alias, owner, charSetId, subType#38
Merged
Merged
Conversation
…subType Add six new fields to the Descriptor struct, populated from IMessageMetadata during statement preparation. This resolves the 'FIXME: more things' placeholder and provides ODBC-level metadata without requiring consumers to use the low-level Firebird API. Fields use the naming requested by the maintainer: - 'name' (from getField) instead of 'field' - 'charSetId' (from getCharSet) instead of 'charSet' Closes asfernandes#37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add six new metadata fields to the
Descriptorstruct, populated fromIMessageMetadataduring statement preparation. This resolves the// FIXME: more thingsplaceholder and provides ODBC-level metadata access without requiring consumers to use the low-level Firebird API directly.Changes
Descriptor.h— Six new fields added toDescriptor:IMessageMetadata)namegetField()relationgetRelation()aliasgetAlias()ownergetOwner()charSetIdgetCharSet()subTypegetSubType()Statement.cpp— Fields populated in theprocessMetadatalambda alongside existing descriptor initialization.test/Statement.cpp— NewdescriptorMetadataFieldstest case that:name,alias,relation,subTypeon output descriptorsNotes
name(notfield) andcharSetId(notcharSet)IMessageMetadataaccessors (getInputMetadata()/getOutputMetadata()) remain available for advanced use casesCloses #37