Skip to content

Commit c15a84d

Browse files
committed
Change std::byte to std::uint8_t in XPBs
1 parent e653f6f commit c15a84d

3 files changed

Lines changed: 12 additions & 13 deletions

File tree

src/lib/Attachment.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -119,15 +119,15 @@ namespace fbcpp
119119
///
120120
/// Returns the DPB (Database Parameter Block) which will be used to connect to the database.
121121
///
122-
const std::vector<std::byte>& getDpb() const
122+
const std::vector<std::uint8_t>& getDpb() const
123123
{
124124
return dpb;
125125
}
126126

127127
///
128128
/// Sets the DPB (Database Parameter Block) which will be used to connect to the database.
129129
///
130-
AttachmentOptions& setDpb(const std::vector<std::byte>& value)
130+
AttachmentOptions& setDpb(const std::vector<std::uint8_t>& value)
131131
{
132132
dpb = value;
133133
return *this;
@@ -136,7 +136,7 @@ namespace fbcpp
136136
///
137137
/// Sets the DPB (Database Parameter Block) which will be used to connect to the database.
138138
///
139-
AttachmentOptions& setDpb(std::vector<std::byte>&& value)
139+
AttachmentOptions& setDpb(std::vector<std::uint8_t>&& value)
140140
{
141141
dpb = std::move(value);
142142
return *this;
@@ -164,7 +164,7 @@ namespace fbcpp
164164
std::optional<std::string> userName;
165165
std::optional<std::string> password;
166166
std::optional<std::string> role;
167-
std::vector<std::byte> dpb;
167+
std::vector<std::uint8_t> dpb;
168168
bool createDatabase = false;
169169
};
170170

src/lib/Blob.h

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,25 +91,24 @@ namespace fbcpp
9191
///
9292
/// Retrieves the blob parameter block (BPB) used during blob operations.
9393
///
94-
const std::vector<std::byte>& getBpb() const noexcept
94+
const std::vector<std::uint8_t>& getBpb() const noexcept
9595
{
9696
return bpb;
9797
}
9898

9999
///
100100
/// Sets the blob parameter block (BPB) using a copy of the provided value.
101101
///
102-
BlobOptions& setBpb(const std::vector<std::byte>& value)
102+
BlobOptions& setBpb(const std::vector<std::uint8_t>& value)
103103
{
104104
bpb = value;
105105
return *this;
106106
}
107107

108-
// FIXME: review all usages of std::byte
109108
///
110109
/// Sets the blob parameter block (BPB) by moving the provided value.
111110
///
112-
BlobOptions& setBpb(std::vector<std::byte>&& value)
111+
BlobOptions& setBpb(std::vector<std::uint8_t>&& value)
113112
{
114113
bpb = std::move(value);
115114
return *this;
@@ -218,7 +217,7 @@ namespace fbcpp
218217
}
219218

220219
private:
221-
std::vector<std::byte> bpb;
220+
std::vector<std::uint8_t> bpb;
222221
std::optional<BlobType> type;
223222
std::optional<BlobType> sourceType;
224223
std::optional<BlobType> targetType;

src/lib/Transaction.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ namespace fbcpp
9090
/// Returns the TPB (Transaction Parameter Block) which will be used to start
9191
/// the transaction.
9292
///
93-
const std::vector<std::byte>& getTpb() const
93+
const std::vector<std::uint8_t>& getTpb() const
9494
{
9595
return tpb;
9696
}
@@ -99,7 +99,7 @@ namespace fbcpp
9999
/// Sets the TPB (Transaction Parameter Block) which will be used to start the
100100
/// transaction.
101101
///
102-
TransactionOptions& setTpb(const std::vector<std::byte>& value)
102+
TransactionOptions& setTpb(const std::vector<std::uint8_t>& value)
103103
{
104104
tpb = value;
105105
return *this;
@@ -109,7 +109,7 @@ namespace fbcpp
109109
/// Sets the TPB (Transaction Parameter Block) which will be used to start the
110110
/// transaction.
111111
///
112-
TransactionOptions& setTpb(std::vector<std::byte>&& value)
112+
TransactionOptions& setTpb(std::vector<std::uint8_t>&& value)
113113
{
114114
tpb = std::move(value);
115115
return *this;
@@ -254,7 +254,7 @@ namespace fbcpp
254254
}
255255

256256
private:
257-
std::vector<std::byte> tpb;
257+
std::vector<std::uint8_t> tpb;
258258
std::optional<TransactionIsolationLevel> isolationLevel;
259259
std::optional<TransactionReadCommittedMode> readCommittedMode;
260260
std::optional<TransactionAccessMode> accessMode;

0 commit comments

Comments
 (0)