Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actuator Board Cleanup #17

Open
davidlenfesty opened this issue Dec 31, 2020 · 1 comment
Open

Actuator Board Cleanup #17

davidlenfesty opened this issue Dec 31, 2020 · 1 comment
Assignees

Comments

@davidlenfesty
Copy link
Contributor

Aside from migrating to using a servo for firing torpedos, the following cleanup tasks should be done.

  • Just use sin function from math.h instead of the custom sin table. It harms readability more than it matters for performance.
  • Convert the handling of actuator commands to use look up tables instead of massive blocks of if statements. Convert values used into integer values to help with this. (or at the least use if/else if instead of just if)
  • Move hardware definitions to a common hardware.h file.
  • General indentation/code formatting fixes.
@davidlenfesty
Copy link
Contributor Author

The comments and stuff I did during the meeting are on the david/torpedo-comments branch, here: https://github.com/arvpUofA/au_teensycode/tree/david/torpedo-comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants