-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mode method #604
Comments
I have a question: there are some distributions that are bimodal. Should we return both modes or just one? |
Good question. Maybe only the major mode? Not sure what to do if two equal modes. Also for the beta and beta scaled, I think we are currently returning 0.5 when alpha and beta are lower than 1. But we should do: 0.5 if α=β = 1 |
One option is to go with the major one, other is to return a tuple of both modes |
yep, probably the better thing is to respect multimodality. Then we will need to check that setting the mode works for |
Have added
|
I believe returning a list or tuple of modes is beneficial. For a bimodal normal mixture, both peaks should be returned. That’s my suggestion. |
In #603 we introduced a mode argument to maxent and a mode method to many distributions. The mode is still missing from the following distributions.
The text was updated successfully, but these errors were encountered: