-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Representing schema in xarray #169
Comments
Also pinging @shoyer in case he has advice for doing this. |
This seems more or less reasonable to me, but note that opening a netCDF file isn't always cheap (this is also true to a lesser extent with creating an xarray.Dataset). I expect you will be happier with caching or eagerly creating Dataset objects rather than recreating them in |
@ColCarroll Should adding a representation of a prior be considered as well? Thinking of this in regards to this issue |
Nevermind, I see that its already mentioned in the schema document |
My thought is that the wrapper above would be used to let arviz decide what plots to "allow", or to throw exceptions with. Once we start adding other data (priors, sampler statistics, observed data, posterior_predictive), I think there are exponentially more interesting visualizations to be done. |
One big benefit is that its a one stop shop for all the data in a model that is interesting as well, so it makes it easier for people new to the field to figure out what to learn |
In order to get to feature parity with pymc3 plotting, we need to have a way to access sampler statistics (specifically, to access divergences), and ppc samples. @aseyboldt outlined a good way to think about the rest of the schema here.
At the same time, xarray supports groups, but it doesn't look like it does so natively (yet? see the discussion at pydata/xarray#1092).
I am proposing something like
This is a pretty light wrapper around netCDF and xarray. Usage is something like
I think this will have to change a little bit so that nested groups work fine. In particular, something like
The text was updated successfully, but these errors were encountered: