Fixed the job status hasEnded() / isActive() helper methods

Author: fulopattila122

src/Models/JobStatus.php

@@ -44,11 +44,11 @@ class JobStatus extends Enum implements JobStatusContract
 
     public function isActive(): bool
     {
-        return $this->isAnyOf(self::QUEUED(), self::PROCESSING());
+        return in_array($this->value(), [static::QUEUED, static::PROCESSING]);
     }
 
     public function hasEnded(): bool
     {
-        return $this->isAnyOf(self::COMPLETED(), self::FAILED());
+        return in_array($this->value(), [static::COMPLETED, static::FAILED]);
     }
 }

tests/JobStatusTest.php

@@ -0,0 +1,38 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Konekt\History\Tests;
+
+use Konekt\History\Models\JobStatus;
+
+class JobStatusTest extends TestCase
+{
+    /** @test */
+    public function it_can_tell_whether_it_has_ended()
+    {
+        $completed = JobStatus::COMPLETED();
+        $failed = JobStatus::FAILED();
+        $queued = JobStatus::QUEUED();
+        $processing = JobStatus::PROCESSING();
+
+        $this->assertTrue($completed->hasEnded());
+        $this->assertTrue($failed->hasEnded());
+        $this->assertFalse($queued->hasEnded());
+        $this->assertFalse($processing->hasEnded());
+    }
+
+    /** @test */
+    public function it_can_tell_whether_it_is_active()
+    {
+        $queued = JobStatus::QUEUED();
+        $processing = JobStatus::PROCESSING();
+        $completed = JobStatus::COMPLETED();
+        $failed = JobStatus::FAILED();
+
+        $this->assertTrue($queued->isActive());
+        $this->assertTrue($processing->isActive());
+        $this->assertFalse($completed->isActive());
+        $this->assertFalse($failed->isActive());
+    }
+}