fix: issue 34, missing files (#38)

* fix: issue 34, missing files

* chore: lint fix

Author: aron-muon

src/api/files.py

@@ -99,13 +99,36 @@ async def upload_file(
 
         uploaded_files = []
 
-        # Create an actual session in Redis for this upload
-        session_metadata = {}
+        # Resolve or create session for this upload.
+        # When entity_id is provided, reuse the existing session for that
+        # entity so that multiple file uploads land in the same session
+        # (fixes issue #34 where separate uploads created isolated sessions).
+        session_id = None
         if entity_id:
-            session_metadata["entity_id"] = entity_id
+            try:
+                existing = await session_service.list_sessions_by_entity(entity_id, limit=1)
+                if existing:
+                    candidate = existing[0]
+                    if getattr(candidate.status, "value", str(candidate.status)) == "active":
+                        session_id = candidate.session_id
+                        logger.info(
+                            "Reusing existing session for entity",
+                            session_id=session_id,
+                            entity_id=entity_id,
+                        )
+            except Exception as e:
+                logger.warning(
+                    "Failed to look up session by entity_id",
+                    entity_id=entity_id,
+                    error=str(e),
+                )
 
-        session = await session_service.create_session(SessionCreate(metadata=session_metadata))
-        session_id = session.session_id
+        if not session_id:
+            session_metadata = {}
+            if entity_id:
+                session_metadata["entity_id"] = entity_id
+            session = await session_service.create_session(SessionCreate(metadata=session_metadata))
+            session_id = session.session_id
 
         for file in upload_files:
             # Read file content

src/services/interfaces.py

@@ -138,6 +138,13 @@ async def cleanup_session_files(self, session_id: str) -> int:
         """Clean up all files for a session. Returns count of deleted files."""
         pass
 
+    @abstractmethod
+    async def store_uploaded_file(
+        self, session_id: str, filename: str, content: bytes, content_type: str | None = None
+    ) -> str:
+        """Store an uploaded file directly. Returns file_id."""
+        pass
+
     @abstractmethod
     async def store_execution_output_file(self, session_id: str, filename: str, content: bytes) -> str:
         """Store a file generated during execution. Returns file_id."""

src/services/orchestrator.py

@@ -348,6 +348,32 @@ async def _mount_files(self, ctx: ExecutionContext) -> list[dict[str, Any]]:
             )
             mounted_ids.add(key)
 
+            # Consolidate cross-session files into the chosen session (issue #34).
+            # When files are uploaded in separate sessions (e.g. entity_id=null),
+            # copy them into the execution session so subsequent requests can find them.
+            if ctx.session_id and file_ref.session_id != ctx.session_id:
+                try:
+                    await self.file_service.store_uploaded_file(
+                        session_id=ctx.session_id,
+                        filename=file_info.filename,
+                        content=content,
+                        content_type=file_info.content_type,
+                    )
+                    logger.info(
+                        "Consolidated cross-session file",
+                        source_session=file_ref.session_id,
+                        target_session=ctx.session_id[:12],
+                        filename=file_info.filename,
+                    )
+                except Exception as e:
+                    logger.warning(
+                        "Failed to consolidate cross-session file",
+                        source_session=file_ref.session_id,
+                        target_session=ctx.session_id[:12],
+                        filename=file_info.filename,
+                        error=str(e),
+                    )
+
             logger.debug(
                 "Mounted file for execution",
                 session_id=file_ref.session_id,